Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
entity system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Aug 2014 at 13:22 UTC
Updated:
10 Aug 2014 at 22:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
yesct commentedpatch coming to investigate this
Comment #2
yesct commentedlocally, I'm getting different fails. Might be a bleed through because I'm running them in the UI.
Is bleedthrough fixed in/by running the run-tests.sh ?
---------
here is, just a rerolled #2226533: Changes to the Language class due to the LanguageInterface (followup) running EntityTranslationTest s 50 times.
Also, are two variations of making id public and using it directly, one in testLanguageFallback() and one in getTranslationFromContext()
locally I was getting different translations (langcode), sometimes l0, sometimes l1, sometimes l2
when evaluating the expression $this->entityManager->getTranslationFromContext($entity, 'l2')
Comment #6
yesct commentedFor just the straight rerolled one, (without changes to direct access of ->id)
1.
2315095.2226533.patch
line X failed Y times out of 50
469 23
476 27
480 27
512 33
2.
2315095.debugging_changes.2226533.testLanguageFallback.patch
469 22
476 28
480 28
512 30
3.
2315095.debugging_changes.2226533.getTranslationFromContext.patch
469 33
476 17
480 17
512 29
I have no real leads... but hope maybe #2246679: Make Language module's LanguageInterface (to be ConfigurableLanguageInterface) extend Core's LanguageInterface might help with this.
Comment #7
xjmDiscussed with @YesCT and @alexpott. While this might indicate some problematic fragility, the test is not actually failing in HEAD and the issue that it's blocking is a normal. So, it wouldn't really make sense to block release on this unless we know of an actual bug. We can re-promote this if we find something nasty behind this random fail.
Comment #8
xjmComment #9
yesct commentedfixed in the patch, the sort was casting as array, and that only gets public properties.