Comments

yesct’s picture

yesct’s picture

locally, I'm getting different fails. Might be a bleed through because I'm running them in the UI.

Is bleedthrough fixed in/by running the run-tests.sh ?

---------

here is, just a rerolled #2226533: Changes to the Language class due to the LanguageInterface (followup) running EntityTranslationTest s 50 times.
Also, are two variations of making id public and using it directly, one in testLanguageFallback() and one in getTranslationFromContext()

locally I was getting different translations (langcode), sometimes l0, sometimes l1, sometimes l2
when evaluating the expression $this->entityManager->getTranslationFromContext($entity, 'l2')

The last submitted patch, 2: 2315095.debugging_changes.2226533.testLanguageFallback.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2315095.2226533.patch, failed testing.

yesct’s picture

For just the straight rerolled one, (without changes to direct access of ->id)

1.
2315095.2226533.patch
line X failed Y times out of 50
469 23
476 27
480 27
512 33

2.
2315095.debugging_changes.2226533.testLanguageFallback.patch
469 22
476 28
480 28
512 30

3.
2315095.debugging_changes.2226533.getTranslationFromContext.patch
469 33
476 17
480 17
512 29

I have no real leads... but hope maybe #2246679: Make Language module's LanguageInterface (to be ConfigurableLanguageInterface) extend Core's LanguageInterface might help with this.

xjm’s picture

Title: EntityTranslationTest webtest random failure » EntityTranslationTest webtest random failure in some patches (not HEAD)
Priority: Critical » Normal

Discussed with @YesCT and @alexpott. While this might indicate some problematic fragility, the test is not actually failing in HEAD and the issue that it's blocking is a normal. So, it wouldn't really make sense to block release on this unless we know of an actual bug. We can re-promote this if we find something nasty behind this random fail.

xjm’s picture

Issue tags: +TCDrupal 2014
yesct’s picture

Status: Needs work » Closed (fixed)

fixed in the patch, the sort was casting as array, and that only gets public properties.