Standardize entity_test entity route names

Some of them also points to routes which do not exist. I think we should in general standardize the available links.

Updated route names, however not sure what should be done with unused items, so they are renamed too.

Fix other routes

Found a bug in comment tests, also fixed missed redirect in add form

Add missed routes

Proper fix for routes, should be green

Fix one more inconsistency

+++ b/core/modules/comment/src/Tests/CommentNonNodeTest.php
@@ -430,6 +430,8 @@ public function testsNonIntegerIdEntities() {
+    // Ensure a core field type shown.
+    $this->assertOption('edit-fields-add-new-field-type', 'boolean');

@@ -440,6 +442,8 @@ public function testsNonIntegerIdEntities() {
+    // Ensure a core field type shown.
+    $this->assertOption('edit-fields-add-new-field-type', 'boolean');

I think we should add this within the conversion because that conversion uncovered that test incomplete

@fago Crell said that it needs your review

re-roll

Meta issue closed #2285413: [Meta] Standardize entity route names because this only one left
Suppose @Berdir knows entity_test better after #1976158: Rename entity storage/list/form/render "controllers" to handlers ;)

Not sure what the question is here even?

Entity test types is just a bunch of entity types used in various test cases. A lot of them only extend EntityTest to add in some custom entity definitions which is then used/tested in a test case. If links are unused / wrong they can/should be removed of course.

@andypost
As you probably saw some of these routes defined here aren't defined but well, this isn't changed but this patch.

I checked this again, and really can't find unused ones...

1. +++ b/core/modules/system/tests/modules/entity_test/entity_test.routing.yml
   @@ -6,35 +6,35 @@ entity_test.render:
   +entity.entity_test.delete_form:
   ...
   +entity.entity_test_mul.delete_form:
   ...
   +entity.entity_test_mulrev.delete_form:
   ...
   +entity.entity_test_rev.delete_form:
   
   +++ b/core/modules/system/tests/modules/entity_test/src/Entity/EntityTest.php
   @@ -41,11 +41,11 @@
   + *     "delete-form" = "entity.entity_test.delete_form",
   
   +++ b/core/modules/system/tests/modules/entity_test/src/Entity/EntityTestMul.php
   @@ -37,11 +37,11 @@
   + *     "delete-form" = "entity.entity_test_mul.delete_form",
   
   +++ b/core/modules/system/tests/modules/entity_test/src/Entity/EntityTestMulRev.php
   @@ -38,9 +38,9 @@
   + *     "delete-form" = "entity.entity_test_mulrev.delete_form",
   
   +++ b/core/modules/system/tests/modules/entity_test/src/Entity/EntityTestRev.php
   @@ -36,9 +36,9 @@
   + *     "delete-form" = "entity.entity_test_rev.delete_form",
   

   delete - fine

2. +++ b/core/modules/system/tests/modules/entity_test/entity_test.routing.yml
   @@ -6,35 +6,35 @@ entity_test.render:
   +entity.entity_test.render_options:
   
   @@ -45,14 +45,14 @@ entity_test.render_options:
   +entity.entity_test.render_no_view_mode:
   ...
   +entity.entity_test.list_referencing_entities:
   

   this is used in tests

mh, maybe I was remembering it wrong.

Committed and pushed to 8.x. Thanks!