Part of #2285413: [Meta] Standardize entity route names. See there for details.

CommentFileSizeAuthor
#4 2314863-4.patch4.57 KBandypost
#4 interdiff.txt1.02 KBandypost
route-names-block-content.patch4.92 KBCrell

Comments

Status: Needs review » Needs work

The last submitted patch, route-names-block-content.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/block_content/block_content.links.contextual.yml
@@ -1,10 +1,10 @@
-  route_name: 'block_content.edit'
+  route_name: 'entity.block_content.canonical'

+++ b/core/modules/block_content/block_content.links.task.yml
@@ -11,17 +11,17 @@ block_content.type_list:
-block_content.edit:
+entity.block_content.canonical:
...
+  route_name: entity.block_content.canonical
+  base_route: entity.block_content.canonical
+entity.block_content.delete_form:

Nope

Crell’s picture

Crell commented

Please define "nope". I don't quite follow.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.02 KB
new 2314863-4.patch4.57 KB

yep, routing changes are wrong

andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed #2317981: Move block content edit and delete routes under admin/content/block to improve IA for editors and fix breadcrumbs

andypost’s picture

andypost
he/him
Primary language Russian
commented

Suppose here it makes sense

+++ b/core/modules/block_content/src/Entity/BlockContent.php
@@ -38,10 +38,10 @@
+ *     "admin-form" = "entity.block_content_type.edit_form"

+++ b/core/modules/block_content/src/Entity/BlockContentType.php
@@ -35,8 +35,8 @@
+ *     "edit-form" = "entity.block_content_type.edit_form"

Related issue https://www.drupal.org/node/2309187

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +TCDrupal 2014

Yes, that's the pattern we're doing for now on admin-form, pending #2309187: Fix double-link-entry between Entity and Entity Type classes.

And duh, now with context I understand what nope meant. :-) Going out on a limb and RTBCing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ac0fe75 and pushed to 8.0.x. Thanks!

  • alexpott committed ac0fe75 on 8.0.x 
    Issue #2314863 by andypost, Crell: Standardize block content entity...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.