Pretty much every contrib module with a d8 version broke because of the introduction of FormStateInterface for the Form API.

RebuildForm and SettingsForm need to be adjusted to use this.

CommentFileSizeAuthor
#3 interdiff.txt690 bytesmradcliffe
#3 2314749-composer_manager-formstateinterface-3.patch4.6 KBmradcliffe
#1 2314749-composer_manager-formstateinterface.patch4.59 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2314749-composer_manager-formstateinterface.patch4.59 KB

This should do it.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Needs work

Patch doesn't work. Form values not saved.

Edit: hurrrr...

$form_state_alues
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2314749-composer_manager-formstateinterface-3.patch4.6 KB
new interdiff.txt690 bytes

Revised patch.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Patch fixes the issue

jbrown’s picture

jbrown commented

Works for me!

jbrown’s picture

jbrown commented

Please apply this.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Works indeed. Will try to ping Mr Cpliakas :)

  • cpliakas committed f90da3e on 8.x-1.x authored by mradcliffe 
    Issue #2314749 by mradcliffe, pcambra, jbrown: Forms broken due to...
cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.