Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I would like to fix it before the API becomes settled.
The changes are of the form...
ContentTranslationHandlerInterface::getSourceLangcode($form_state) should be
ContentTranslationHandlerInterface::getSourceLangcode(FormStateInterface $form_state)
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | form_state-2313823-4.patch | 45.49 KB | tim.plunkett |
| #4 | form_state-2313823-4.patch | 45.49 KB | tim.plunkett |
| FormState-0.patch | 1.34 KB | martin107 | |
Comments
Comment #1
martin107 CreditAttribution: martin107 commentedIts is been suggested that should be covered by one of the existing FormState issues...
I have to say I have looked and found that it was not covered.
I am broadening the scope to look for similar examples in core - here is what I have found in other places.
\Drupal\search\Plugin\SearchPluginBase::buildSearchUrlQuery($form_state)
\Drupal\views\Form\ViewsForm::getFormObject($form_state)
admin.inc views_ui_build_form_path($form_state)
\Drupal\system\Form\ModulesListForm::buildModuleList($form_state)
Comment #2
martin107 CreditAttribution: martin107 commentedComment #4
tim.plunkettI didn't have an issue but I did have a patch. Thanks @martin107!
Comment #6
tim.plunkettUghhh.
Comment #8
tim.plunkettProbably need to reupload it, actually.
Comment #9
martin107 CreditAttribution: martin107 commentedAll my finds are addressed and then some. so +1
In terms of review, all changes are in scope, and appropriate.
Summary changes - No longer a two line fix.
Comment #10
longwave#8 looks good to me. I see no further functions that should be typehinted with
grep -r form_state core | grep function | grep -v FormStateComment #11
alexpottCommitted 5f4bbab and pushed to 8.x. Thanks!