Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
forms system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Jul 2014 at 17:54 UTC
Updated:
22 Aug 2014 at 19:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettComment #2
jibranI haven't seen any test code for this method. I think we should add some quick unit test for it.
Are we still using it in
FormBuilde? Perhaps we can remove it.Comment #3
tim.plunkettWe are still using NestedArray in FormBuilder for other things.
Here's a test.
Comment #4
jibranThank you RTBC.
Comment #5
alexpottNeeds a reroll plus can someone work out which CRs need updating.
Comment #6
tim.plunkettHere's the reroll, will find the CR next.
Comment #7
tim.plunkettHmm, there were no CRs pointing to FormBuilderInterface::setValue(), and none about form_set_value(), which still exists.
So this either needs one now, or we write one when we kill the actual functions.
Comment #8
jibranThanks for the reroll. Back to RTBC.
Comment #9
tim.plunkettPosted https://www.drupal.org/node/2315243 now instead of later.
Comment #10
alexpottI deleted https://www.drupal.org/node/2315243 and added this to https://www.drupal.org/node/2121003
Comment #11
webchickWell that's definitely much nicer.
Committed and pushed to 8.x. Thanks!
Comment #13
tim.plunkettThanks!