If you go to admin/structure/menu and click the 'add link' button next to one of the menus, you get taken to admin/structure/menu/add?menu=main which is the form for adding a new menu rather than a link.

CommentFileSizeAuthor
#12 interdiff.txt1.67 KBolli
#12 menu_link_add-2312925-12.patch1.95 KBolli
#10 interdiff.txt722 bytesolli
#10 menu_link_add-2312925-10.patch2.18 KBolli
#8 menu_link_add-2312925-8.patch2.18 KBdawehner
#4 2312925-menu-link-bug-2-test-only.patch712 byteskim.pepper
#2 2312925-menu-link-bug-test-only.patch1.61 MBkim.pepper
add-menu-link.png78.4 KBkim.pepper

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +Needs tests
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2312925-menu-link-bug-test-only.patch1.61 MB

I think this assertion shows the link is incorrect. No idea how to fix it though!

Status: Needs review » Needs work

The last submitted patch, 2: 2312925-menu-link-bug-test-only.patch, failed testing.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
StatusFileSize
new 2312925-menu-link-bug-2-test-only.patch712 bytes

Hmm. Accidentally diffed against the 8.x branch instead of the 8.0.x branch.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented 
+++ b/core/modules/menu_ui/src/Tests/MenuTest.php
@@ -249,6 +249,10 @@ function doMenuTests() {
+    $this->assertLinkByHref('admin/structure/menu/manage/' . $menu_name . '/add', "The add menu link button url is correct");

I think the path needs to have a forward slash. Also, not sure if there should be query string params (destination?)

Status: Needs review » Needs work

The last submitted patch, 4: 2312925-menu-link-bug-2-test-only.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new menu_link_add-2312925-8.patch2.18 KB

I think this assertion shows the link is incorrect. No idea how to fix it though!

We can collaborate on that.

Status: Needs review » Needs work

The last submitted patch, 8: menu_link_add-2312925-8.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new menu_link_add-2312925-10.patch2.18 KB
new interdiff.txt722 bytes

Fixed the test.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented 
+++ b/core/modules/menu_ui/menu_ui.module
@@ -76,6 +76,9 @@ function menu_ui_entity_type_build(array &$entity_types) {
+  if (isset($entity_types['menu_link_content'])) {

+++ b/core/modules/menu_ui/src/MenuListBuilder.php
@@ -51,10 +51,12 @@ public function getDefaultOperations(EntityInterface $entity) {
+      if ($this->moduleHandler()->moduleExists('menu_link_content')) {

menu_ui.info.yml lists a dependency on menu_link_content, so no need for the checks.

olli’s picture

olli commented
StatusFileSize
new menu_link_add-2312925-12.patch1.95 KB
new interdiff.txt1.67 KB

Removed the checks, filed #2313263: Page not found after adding, editing or deleting a menu link.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

I think this looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

@tim.plunkett Me too :)

Committed e3833d0 and pushed to 8.x. Thanks!

  • alexpott committed e3833d0 on 8.0.x 
    Issue #2312925 by olli, kim.pepper, dawehner: Fixed 'Add Link' button...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.