There should a configuration where we can set custom subscription link text. Currently it says: "Subscribe to group", and there is not setting where we can change this. This feature will help increasing the usability of this module.

CommentFileSizeAuthor
#1 link_settings-2310567-1.patch6.99 KBsubhojit777

Comments

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Active » Needs review
StatusFileSize
new link_settings-2310567-1.patch6.99 KB

This patch provides settings settings so that you can configure subscription/unsubscription link text. Also provides setting to attach CSS class to the link. I have not added the case for "group cardinality", dont know how it works, as I am using organic groups for the first time. Any idea on how it works will be very helpful, will update the patch according to that.

shushu’s picture

shushu commented
Status: Needs review » Needs work

Thanks for the patch.

While the code seems proper and works as expected, I am not certain it is the proper solution.
Before the patch the texts passed via t(), which meant they will fit to any language.
After the patch, the texts pass t() only during settings, which means, as far as I get it, that they won't be translated to the user's language.
Passing user input via t() is not a proper solution as well, so we can't pass the user input via t() when showing it.
Can you look for other examples in other modules, how do they support both customization and multi-language ?

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

@shushu I can understand. You can see that default setting are enclosed within t(). So the default value will be translated. And any other text will be handled by field module itself. The closest I saw is cloud zoom module and it provides formatter settings, but most of them are select list settings. Can you name some modules that has text settings.

shushu’s picture

shushu commented
Status: Needs work » Closed (works as designed)

Sorry, we will keep it as is. For customization there are many ways you can use, hooks and themeing, so we better leave the strings translated rather than customize-able.

jweirather’s picture

jweirather commented

@subhojit777: thank you thank you thank you -- I'm sure many readers will find your patch valuable. I hope something like it is rolled into a future release. Preferably where each group type (content type) could have its own labels, though I'm sure that's easer said than done.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

I am glad this helped :)

thetwentyseven’s picture

thetwentyseven commented

Thanks for the patch! For those like me who could not find where to change the settings, go to Administration » Structure » Content types » "your-content-type" » Manage display. Select the "Group" field, open it with the little icon on the right and there you can see all the new fields that can be edited.