Hello.

Just stumbled across this on Drupal 7, but see now that this is also present in drupal 8.

I tried to search if someone else posted a patch for this, but could not find it. If that is the case, feel free to close this :)

Now, I am not a native english speaker, but it seems to be some suboptimal grammar in these sentences. In addition to a flat out typo (vebose -> verbose).

Attaching a couple of minor patches for Drupal 8 and Drupal 7. As I said, English is not my first language, so please feel free to chime in on the wording i chose.

Have a nice weekend everyone!

Comments

eiriksm’s picture

StatusFileSize
new780 bytes

Patch for Drupal 8

eiriksm’s picture

StatusFileSize
new744 bytes

Patch for Drupal 7

Status: Needs review » Needs work

The last submitted patch, 2: docs-typo-2309687-2.patch, failed testing.

eiriksm’s picture

Status: Needs work » Needs review

Hm, not sure if this tests all over again if I set back to "needs review"

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

The Drupal 8 patch looks good to me, thanks!

Normally we don't upload a Drupal 7 patch until Drupal 8 is finished. See
https://www.drupal.org/node/1319154#multiple-versions

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ac76e2c and pushed to 8.x. Thanks!

  • alexpott committed ac76e2c on 8.x
    Issue #2309687 by eiriksm: Fixed Typo in docs for function Testclass::...
eiriksm’s picture

Normally we don't upload a Drupal 7 patch until Drupal 8 is finished. See
https://www.drupal.org/node/1319154#multiple-versions

Ah, I thought I remembered something like that. Thanks!

So would it be appropriate to now reupload the patch and change the version to 7.x and status to needs review?

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Status: Fixed » Reviewed & tested by the community

We actually don't need to upload it again. The D7 patch looks fine. I'll just set status/version and click "retest" so that the test bot will test it against Drupal 7.

jhodgdon queued 2: docs-typo-2309687-2.patch for re-testing.

  • jhodgdon committed 7ca0dfe on 7.x
    Issue #2309687 by eriksm: Fix typo in docs for verbose test class method
    
jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks again! Committed to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.