Documentation incorrect for 7 special node hooks

Wow, good catch! This issue report is accurate -- if you look at function node_invoke(), which actually does the invokes, it is doing what you say.

However, I think the patch itself needs some work:

a) Proofreading -- such as spelling and "it's" instead of "its".

b) There are extra spaces (do not leave two spaces between sentences, only one).

c) I think it is a bit confusing. It could be pretty simple. Just say essentially:

When you define a node type, you give it a "base". All of the node-type-specific hooks (list them), instead of being named mymodule_hookname(), as they would be for normal hooks in module mymodule, are named base_hookname() instead.

I don't think the documentation needs to be this verbose.

This is great!

A few minor things to fix:

a) Lists in API documentation do not support paragraph breaks within a single list item. So you should just wrap the text together, in:

...
+ *   'mymodule' for example). Only the node type's corresponding implementation
+ *   is invoked.
+ *   For example, poll_node_info() in poll.module defines the base for the
...

b) You cannot use @see inside of documentation paragraphs. @see goes at the end. Use @link to make links within text. So:

+ *     hooks that respond to this node type. Base is usually the name of the
+ *     module or 'node_content', but not always.
+ *     @see node_api_hooks

should become something like

+ *     hooks that respond to this node type. Base is usually the name of the
+ *     module or 'node_content', but not always. See
+ *     @link node_api_hooks Node API hooks @endlink for more information.

And

+ * This node-type-specific hook is invoked only for specified node types.
+ * @see node_api_hooks

needs a similar change.... but maybe on each hook we should say something like:

This is a node-type-specific hook, which is invoked only for the node type being affected. Also, instead of the function name prefix being the module name, it is the "base" of the node type. See @link node_api_hooks Node API hooks @endlink for more information.

It seems like it is pretty important here to know that the function name is not like other hooks?

Incorporated above mentioned changes in this patch. Please review updated patch.

Looks great!

I did notice one thing I think we should fix, in hook_form():

+ *
+ * Use hook_form_alter() to respond to node forms for all node types.

We should not advise using hook_form_alter(). People would be better of using hook_form_BASE_FORM_ID() alter, since it is more specific. So we should say something like:

Use hook_form_BASE_FORM_ID_alter(), with base form ID 'node_form', to alter node forms for all node types.

The rest looks perfect, thanks!

Please review updated patch with #7 changes.

Thanks for the quick update!

Thanks again! Committed to 7.x.