Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
forms system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Jul 2014 at 13:35 UTC
Updated:
6 Aug 2014 at 17:45 UTC
Jump to comment: Most recent
Comments
Comment #1
tim.plunkettWe split it off from 'redirect' to make it easier to convert from strings to array/Url. Ideally we'd eventually finish that, and reclaim 'redirect'.
Or, we can just wait for #2225353: Convert $form_state to an object and provide methods like setError() and use $form_state->setRedirect().
Comment #2
jibranArghhh what was this issue #2105661: Add support for $form_state['redirect_route'] then. We are back to where we started. Can someone please explain to me why we are doing it again? Shall we revisit this once again when we'll have a change of heart and we'll want to change all the things to use routes? There is nothing in the issue summary here at #2305023: Rename getCancelRoute to getCancelUrl.
Comment #3
tim.plunkettAll of them should be $form_state->setRedirect(), and it should accept \Drupal\Core\Url.
NO ONE should care what the key is called internally.
Comment #4
jibranNO ONE knows #2225353: Convert $form_state to an object and provide methods like setError() is happening or not I haven't seen any core committer signing it off. In D7 I have to create forms every other day and everyone is going to create forms in D8 as well so I care.
Comment #5
jibranNo need for this after #2189661: Replace $form_state['redirect_route'] with setRedirect() and #2315807: Remove support for path-based form redirects