Problem/Motivation

See #2225353-51: Convert $form_state to an object and provide methods like setError() point 2

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 interdiff.txt1.08 KBtim.plunkett
#8 form_state-2308821-8.patch109.71 KBtim.plunkett
#5 interdiff.txt2.75 KBtim.plunkett
#5 form_state-2308821-5.patch101.4 KBtim.plunkett
#3 form_state-2308821-3.patch98.86 KBtim.plunkett
#2 form_state-2308821-2.patch61.67 KBtim.plunkett

Comments

yesct’s picture

yesct commented
Title: Replace FormBase::setFormError() with $form_state->setErrorByName() » Replace deprecated FormBase::setFormError() with $form_state->setErrorByName()
Issue tags: +@deprecated
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

When the parent gets in, and this goes active, we should add it to the summary in #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs review
StatusFileSize
new form_state-2308821-2.patch61.67 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Replace deprecated FormBase::setFormError() with $form_state->setErrorByName() » Replace FormErrorInterface with $form_state->setErrorByName() and $form_state->setError()
StatusFileSize
new form_state-2308821-3.patch98.86 KB

Status: Needs review » Needs work

The last submitted patch, 3: form_state-2308821-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new form_state-2308821-5.patch101.4 KB
new interdiff.txt2.75 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +FormState

Status: Needs review » Needs work

The last submitted patch, 5: form_state-2308821-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new form_state-2308821-8.patch109.71 KB
new interdiff.txt1.08 KB

Missed one more.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Normal » Major

Let's get this is before the old interface starts proliferating more.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Thanks simple enough so RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs change record updates

Committed 537457b and pushed to 8.x. Thanks!

Need to update https://www.drupal.org/node/2121003, https://www.drupal.org/node/2186135 and add this issue to those CRs.

Also need to also update:

  • alexpott committed 537457b on 8.0.x 
    Issue #2308821 by tim.plunkett: Replace FormErrorInterface with $...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Updated https://www.drupal.org/node/2121003 Need review.
Updated https://www.drupal.org/node/2186135 Need review.
Updated https://www.drupal.org/node/2142817 Need review.
Fixed https://www.drupal.org/node/1876710
Fixed https://www.drupal.org/node/2190815
Fixed https://www.drupal.org/node/2241767/

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.