It doesn't make a lot of sense to split settings between the admin settings page and the block settings page, especially since only a single block is provided. The latter isn't very discoverable either. The attached patch changes this.

CommentFileSizeAuthor
open_readspeaker-move_settings--0-D7.patch5.41 KBtorpy

Comments

killua99’s picture

killua99 commented
Status: Needs review » Postponed (maintainer needs more info)

What about you have an editor role and an admin role and you don't want to mix this settings ?

torpy’s picture

torpy commented
Status: Postponed (maintainer needs more info) » Needs review

It wouldn't help, the variables are still set globally with the block method and don't change depending on role.

killua99’s picture

killua99 commented

No, I'm talking on edit this settings. If you need for some reason some CRM team / editor team don't see /touch the "delicate" settings you might worry about it.

In the block settings are what you need edit the text and so. In the config settings you have what you need to setup the service.

Don't see the point for real.

killua99’s picture

killua99 commented
Priority: Normal » Minor
Status: Needs review » Postponed

I'll postponed this issue. If you can redo others patch with require this one will be good.

torpy’s picture

torpy commented

I'm still not convinced the block settings page is the place to put those. Maybe an extra permission that then controls what fields you see on the admin page?

It'd work out to be better control for site admins as well. They don't need to give the editorial team access to entire block admin page if they don't want to.

Essentially, the 'acount_settings' fieldset would only be accessible by users with 'administer open_readspeaker'. The 'read_settings' fieldset would then be accessible by users with 'administer open_readspeaker' and those with 'manage open_readspeaker' (or whatever the second permission is).

mpp’s picture

mpp commented
Status: Postponed » Closed (works as designed)

Let's close this for now as this is an old Drupal 7 patch and hasn't had any port to Drupal 8.

Also, in Drupal 8 multiple blocks can be created so different reader blocks can be created with different settings which makes it a 'feature'.