Several months back we began work on a Beanstream integration module for Drupal Commerce, and somehow missed the existence of this project in our initial survey until quite recently. Had we realized sooner, I would have submitted patches to this project directly, but instead have built out much of the functionality on its own in a GitHub repository (https://github.com/rnao/commerce_beanstream), covering a couple use-cases this module doesn't (card on file, void transactions), and ignoring at least one other that this one does (capture-only).
While much of the original logic overlaps, I don't currently see an easy way to offer a patch to this module's 1.x-dev branch to merge in the extra features. As such, I'd like to offer to share maintainership of this module and import our github repository as a 2.x branch. We could subsequently merge in the Capture functionality, and any other niceties (error-handling might be better on the 1.x branch, not sure) to generally improve the whole thing. Does this sound workable, or is there some other way I can contribute our efforts back to this project so as to be generally useful?
Here's the GitHub repo: https://github.com/rnao/commerce_beanstream
Thanks,
Derek
Comments
Comment #1
fp commentedHi Derek - Sounds good. Let's work towards merging them together.
I haven't touched this module in a while but it's coming back into my lap, so your timing is good.
Thanks.
Comment #2
spidermanOk that's great- just want to make sure you're good with the plan to make a 2.x branch and import our github code as-is, and then we can start porting features/code from the 1.x branch over? If so, I'll go ahead and push our code up tomorrow!
Thanks,
Derek
Comment #3
fp commentedYes. I haven't fully reviewed your code, I think this makes sense.
Cheers!
Comment #4
spidermanOk it's done 7.x-2.x dev branch created and pushed with the full history of our module. Let me know when you have a chance to review- I'll be away on vacation as of Friday this week, but when I get back in late August, will begin looking to merge existing functionality from 1.x and perhaps think through an upgrade path for those already using the module?
Comment #5
spidermanBased on the excellent work of my colleague kylesmith, who contributed the last 3 patches I just committed, I'm adding Kyle as a maintainer on this module.
Comment #6
fp commentedRight on. Thanks folks.