There are a couple of usecases for generating links/urls.
(new URL($route_name))->toString()(new URL($external_url))->toString()LinkGeneratorInterface->generate($text, $route_name)l()Let's reuse most of the logic of the link generator for the l method(). Introduces LinkGeneratorInterface->generateFromPath($path)
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | link-2306901-11.patch | 11.35 KB | dawehner |
| #9 | link_generator-2306901-8.patch | 8.33 KB | dawehner |
| #5 | interdiff.txt | 1.05 KB | dawehner |
| #5 | link_generator-2306901-5.patch | 8.29 KB | dawehner |
| #1 | link_generator-2306901-1.patch | 7.89 KB | dawehner |
Comments
Comment #1
dawehnerComment #3
Crell commentedAdding issue summary. +1 on this.
If l() isn't already marked @deprecated, this issue should mark it as such.
Comment #4
dawehner.
Comment #5
dawehnerLet's see whether catching the exception would work.
Comment #6
Crell commentedComment #8
xjmComment #9
dawehnerLet's reroll and see what is going on.
Comment #11
dawehnerLet's do it as simple as possible now, just move over the content.
Comment #12
Crell commentedThis contains the API change; any further refactoring shouldn't impact the API so I'm fine with it as is, with non-critical followups to clean up the code if we feel like it. My one question is the method name. "uriReference" is not at all what I would have thought to call the thing we're passing to the method. Can we think briefly on a better name (and if we can't find one, screw it, let's not bikeshed for too long)?
Comment #13
effulgentsia commentedIs there anything here that's still relevant?
Comment #14
dawehnerNo, its not, juhuu
Comment #15
xjmDuplicate actually I think