Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

CommentFileSizeAuthor
#6 interdiff-remove-user_access-2306429-1-6.txt793 bytesKarlKedrovsky
#6 remove-user_access-2306429-6.patch1.98 KBKarlKedrovsky
#1 remove-user_access-2306429-1.patch1.21 KBa_thakur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Active » Needs review
FileSize
remove-user_access-2306429-1.patch1.21 KB

Please find the attached file.

Status: Needs review » Needs work

The last submitted patch, 1: remove-user_access-2306429-1.patch, failed testing.

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Issue tags: +@deprecated
a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Needs work » Postponed

Changing status, will update this when https://www.drupal.org/node/2062043 is fixed.

KarlKedrovsky’s picture

KarlKedrovsky CreditAttribution: KarlKedrovsky commented
Status: Postponed » Needs review

#2062043: Replace user_access() calls with $account->hasPermission() in core files is fixed. Un-postponing this issue.

I'm going to review this now.

KarlKedrovsky’s picture

KarlKedrovsky CreditAttribution: KarlKedrovsky commented
FileSize
remove-user_access-2306429-6.patch1.98 KB
interdiff-remove-user_access-2306429-1-6.txt793 bytes

I looked at the patch and ensured that all the comments and the function were removed and that no additional lines were added or change.

I searched the Drupal 8 code base to ensure no other references to the function existed and found a reference to the old function in a callback description that I believe should have been changed to the new method.

I also found the following similar functions or strings that I do not think we need to change:

  • _tracker_user_access() in core/modules/tracker/tracker.module
  • user_views_data() in core/modules/tracker/tracker.module uses "user_access" in a data string

Am I right that these two thing don't need to be changed.

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Assigned: Unassigned » socketwench

Reviewing...

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Assigned: socketwench » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Can we add this issue to the relevant change record. Thanks.

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Needs work » Needs review

Done. Please check https://www.drupal.org/node/2049309

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 53b024d and pushed to 8.x. Thanks!

  • alexpott committed 53b024d on 8.x 
    Issue #2306429 by KarlKedrovsky, a_thakur: Remove user_access().

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.