Problem/Motivation

Proposed resolution

Overidable services:

  • lock
  • menu.tree_storage
  • router.route_provider
  • router.dumper
  • path.alias_storage
  • flood
  • batch.storage
  • session_manager
  • user.data

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#9 services-2306071-9.patch9.32 KBdawehner
#7 interdiff.txt893 bytesdawehner
#7 services-2306071-7.patch7.89 KBdawehner
#6 interdiff.txt724 bytesdawehner
#6 services-2306071-6.patch7.63 KBdawehner
#4 2306071.patch7.62 KBdawehner
#4 interdiff.txt4.61 KBdawehner
#1 2306071.patch3.2 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Priority: Normal » Major
Issue summary: View changes
StatusFileSize
new 2306071.patch3.2 KB

This is probably not all you need, but sure feel free to expand the list.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review

moeh

chx’s picture

chx commented

#2224635: [META] Services injecting @database in core has a nice collection.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt4.61 KB
new 2306071.patch7.62 KB

There are services which don't really make sense to be swapped out with our tagged backends: cache.backend.database. keyvalue.expireable.database, queue.factory
Alternative I could imagine that choosing the default for these factories could be chosen using the tag.

Status: Needs review » Needs work

The last submitted patch, 4: 2306071.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new services-2306071-6.patch7.63 KB
new interdiff.txt724 bytes

oh.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new services-2306071-7.patch7.89 KB
new interdiff.txt893 bytes

@chx spotted a couple of instances.

chx’s picture

chx commented
  1. forum_manager
  2. menu.tree_storage
  3. entity.query.sql this is an interesting one; but I believe we should make it overrideable so that it's optimizable per SQL engine independently of the storage controller. Yes it makes no sense for a NoSQL engine but those won't provide an override for this one.
  4. Finally, logger.dblog with the same logic.
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new services-2306071-9.patch9.32 KB

With the same reasons we should add config.storage.active to the list.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Let's do this. We can tweak this later.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e7e7666 and pushed to 8.x. Thanks!

  • alexpott committed e7e7666 on 8.0.x 
    Issue #2306071 by dawehner: Tag backend services.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.