Problem/Motivation

When adding a contextual filter User: Uid in views, select User ID as the argument validator. "Restrict to the selected roles" checkboxes are visible even if "Restrict user based on role" is not checked.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 2305293-4.patch2.39 KBolli
#4 2305293-4.patch2.39 KBolli
#4 2305293-test_only.patch1.06 KBolli
views_uid_restrict_roles_states.patch1.33 KBolli

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

Note: it used to be the key "user", it is "entity:user" in HEAD but the state uses the wrong ID.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

I guess this is testable.

dawehner’s picture

dawehner
Primary language German
commented

well right, you could test the exact output of the HTML.

olli’s picture

olli commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2305293-test_only.patch1.06 KB
new 2305293-4.patch2.39 KB

The last submitted patch, 4: 2305293-test_only.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you for writing the test!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2305293-4.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2305293-4.patch2.39 KB

Re-upload.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ceb595d and pushed to 8.x. Thanks!

  • alexpott committed ceb595d on 8.x 
    Issue #2305293 by olli: Fixed Wrong #states for "Restrict to the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.