Live preview for the Add content item widget does not respond to keyboard events, only to mouse clicks.

To reproduce:

  1. Install latest Panopoly and include demo content.
  2. Go to the Lovely Vegetables page at content/lovely-vegetables
  3. Customize the page
  4. Add a pane
  5. Choose Add content item
  6. Note the live preview shows the item Lovely Vegetables
  7. In the Piece of Content field, type "veg"
  8. Using the arrow key, arrow down to select Vegetables are Great
  9. Hit the Tab key
  10. Note the Live Preview spins for a second, but still displays Lovely Vegetables
  11. Click the Save button
  12. Note that the widget displays the Vegetables are Great item from the autocomplete box, not the Lovely Vegetables item that was in the live preview.

Screenshot showing live preview displaying the wrong content item

CommentFileSizeAuthor
#2 panopoly_magic-preview-keyboard-2303755-2.patch862 bytesdsnopek
#1 panopoly-preview-keyboard.png416.84 KBcboyden

Comments

cboyden’s picture

cboyden commented
Issue summary: View changes
StatusFileSize
new panopoly-preview-keyboard.png416.84 KB
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_magic-preview-keyboard-2303755-2.patch862 bytes

Thanks for the report! I'm able to reproduce.

Attached is a patch that will update the live preview when you press TAB. Please let me know if it works for you! Any extra keyboard related testing on this patch would also be much appreciated. :-)

It will also update the live preview when you press enter on the autocomplete item, but that depends on this other issue which just got committed:

#2304465: Autocomplete loses item selected via keyboard in CTools dialog

cboyden’s picture

cboyden commented
Status: Needs review » Reviewed & tested by the community

I tested with the commit in #2 in place. Works fine. Aside from the known issues with CTools modals in Firefox, this is all OK using the keyboard.

  • dsnopek committed 636db92 on 7.x-1.x 
    Update Panopoly Magic for #2303755 by dsnopek | cboyden: Fixed Live...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed! Let's see what Travis-CI says:

https://travis-ci.org/panopoly/panopoly/builds/30478646

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.