Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
request processing system
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Jul 2014 at 18:49 UTC
Updated:
4 Oct 2014 at 00:20 UTC
Jump to comment: Most recent
Comments
Comment #1
dawehnerSee \Drupal\Core\EventSubscriber\ReverseProxySubscriber ... so are you sure that we need this?
Maybe we do have to adapt the priority of this listener or actually implement it with stackphp.
Given that this is a bug we should consider to write a test, if it really does not work.
Comment #2
bzrudi71 commentedComment #3
judahtanthony commentedThe reason I put it here was because you have to know that you are behind a proxy before you call $request->isSecure() as the proxy can terminate the SSL connection, and just passes on a header to flag it as a secure connection. $request->isSecure() correctly looks for the header, but it needs to be informed first.
Comment #4
alexpottNice find.
Comment #5
dawehnerJust a random example where a stack based approach could help.
Comment #6
dawehnerLet's mark it postponed #2303673: Implement stackphp; cleanup handlePageCache() and preHandle()
Comment #7
dawehnerYeah one less critical!!