Follow-up to #2302331: Move drupal_valid_path to PathValidator service

Problem/Motivation

We want to remove include files (including path.inc) and move from procedural to OO code.

Proposed resolution

Replace instances of deprecated drupal_valid_path with PathValidator

Remaining tasks

RTBC

User interface changes

None

API changes

drupal_valid_path() becomes deprecated

CommentFileSizeAuthor
#3 2303361-path_validator-3.patch6.68 KBtim.plunkett
#1 2303361-remove-valid-path-1.patch8.58 KBkim.pepper

Comments

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
StatusFileSize
new 2303361-remove-valid-path-1.patch8.58 KB

This replaces all found usages of drupal_valid_path().

dawehner’s picture

dawehner
Primary language German
commented

It would be great to skip the changes in menu for a while, given that they will otherwise conflict with the MENU beta deadline issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new 2303361-path_validator-3.patch6.68 KB

Rerolled. Much less to do now.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Seems legit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 332fad7 and pushed to 8.0.x. Thanks!

  • alexpott committed 332fad7 on 8.0.x 
    Issue #2303361 by tim.plunkett, kim.pepper: Replace instances of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.