Show path dialog when adding a path based display

If your rest display should work like a page display use the clone display as rest export functionality.

People will disagree with that statement, but I really think this is a feature request not a task. Hard coding everything is a bad behavior,
given that in order to make the path usefull really working you basically want to have the same filters, fields, contextual filters and access configuration aka clone.

An alternative, which at least improve things, would be to automatically open the path modal when you add a new rest display.

Patch is re-rolled. It's not working as expected, cause is probably:

$view->addFormToStack('display', $display_id, 'menu');

The path modal does not come up as expected according to #2

This does not seem trivial according to @dawehner@irc

Checking addFormToStack

  /**
   * Add another form to the stack; clicking 'apply' will go to this form
   * rather than closing the ajax popup.
   */
  public function addFormToStack($key, $display_id, $type, $id = NULL, $top = FALSE, $rebuild_keys = FALSE) {

it suggests we have an overlay but that's not true. We just clicked the 'Add REST export' button.

Worked on it, total different approach.

Nice rephrase solution. Works as described in #2

This solved the required path for (rest export) path displays by adding a dialog but what if two or more fields are required? The patch from #3 suggested we can add multiple items to the form stack.

I like the solution of #8 but let @webchick RTBC

Maybe @Helpermedia can do another review?

@dawehner asked me to review this, but I don't feel qualified to review this. I think @tim.plunkett would be a better candidate. (None of this even touches the REST module btw: 0 changes in \Drupal\rest\Plugin\views\display\RestExport.)

@wim-leers changing the title doesn't fix the 0 rest related changes ;-)

This patch pops-up the path dialog for any page based display.

@Wim Leers
Well, the reason to review that was related with the javascript additions ...

This patch pops-up the path dialog for any page based display.

Don't we want that all the time? Seems like a super reasonable assumptions for me at least.

Patch needed a re-roll. I took a3fd4d0f8cf5c5c as a start.

Adding a new (path based) display does not trigger the path dialogue so needs work too.

Having this improvement may fix a real bug.

Just some quick nitpick review :)

1. +++ b/core/modules/views/src/Plugin/views/display/PathPluginBase.php
   @@ -527,7 +527,8 @@ public function getAlteredRouteNames() {
       */
   -  public function remove() {
   +  public function remove()
   +  {
   

   unrelated change

2. +++ b/core/modules/views/src/Plugin/views/display/PathPluginBase.php
   @@ -536,4 +537,8 @@ public function remove() {
    
   +  public function mainDisplaySection() {
   +    return 'path';
   +  }
   

   Let's put {@inheritdoc} on there

Curious what the subsystem maintainer things? Also some changes were requested in last comment

i'm rerolling the patch as seen that #15 was too old so it cannot apply to the current version 10.1.x, addresses the comment #17. And attaching the reroll file for the same.

Fixed #32.
Please review.