Tests failed on "selection" profile field type:

Running d6_filter_format [ok]
Running d6_user_role [ok]
Running d6_user_picture_field [ok]
Running d6_user_picture_field_instance [ok]
Running d6_user_picture_entity_display [ok]
Running d6_user_picture_entity_form_display [ok]
Running d6_user_picture_file [ok]
Running d6_user [ok]
Running d6_user_profile_field [ok]
The configuration property settings.allowed_values.etc. doesn't exist. [error]
(/var/www/drupal/core/lib/Drupal/Core/Config/Schema/Mapping.php:66)
Running d6_user_profile_field_instance [ok]
Attempt to create an instance of field profile_color that does not exist on entity type user. [error]
(/var/www/drupal/core/modules/field/src/Entity/FieldInstanceConfig.php:472)
Running d6_user_profile_entity_display [ok]
Running d6_user_profile_entity_form_display [ok]
Running d6_profile_values:user [ok]

The reason it failed is because I had a profile field of type "selection" (aka. list) called profile_color. The selection options were:

"Red
Blue
Green
etc." < the dot is the problem.

CommentFileSizeAuthor
#16 2302253-16.patch10.03 KBultimike
#11 2302253-10.patch16.6 KBultimike
#9 2302253-9.patch7.13 KBultimike

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: User profile "selection" type field type does not migrate from D6 if any of the entries contain a dot » User profile "selection" type field type does not migrate from D6 if any of the available options contain a dot
Anonymous’s picture

Anonymous (not verified) commented
Parent issue: » #2224001: Manual testing (D6->D8): User and User Profile
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

I suspect this has something to do with #2293773: Field allowed values use dots in key names - not allowed in config.

-mike

chx’s picture

chx commented

Yes, since that's in is this an issue still?

joemoraca’s picture

joemoraca commented

I just tested this and it "passes" now.

Added profile field with 3 options one of which had . in it
created new user (with . in username - just to see) then choose option with .

ran D6Manifest-User.yml and it migrated correctly
also checked "field settings" and they also were migrated.

chx’s picture

chx commented

Thanks. This indeed should indeed be fixed now. Could you retest with slashes please? (It's the new CMI separator.)

Edit: / this slash.

joemoraca’s picture

joemoraca commented

Tested with both / and \ and we are good with either.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

I chatted with joemoraca about this - he is updating the d6_user test for this issue.

Joe - when you see this, please assign it to yourself.

-mike

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Active » Needs review
StatusFileSize
new 2302253-9.patch7.13 KB

Too slow, Joe :p

I just updated the Drupal6User dump and MigrateProfileValues test to test for dots, forward slashes, and backward slashes in configuration values.

While I was in there, I did a few other minor-cleanups:

  1. I renamed MigrateProfileValues to MigrateUserProfileValues so it is consistent with the other user-related test classes.
  2. I replaced a deprecated user_load() and file_load() in MigrateUserTest.

Patch attached.

Thanks,
-mike

Status: Needs review » Needs work

The last submitted patch, 9: 2302253-9.patch, failed testing.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2302253-10.patch16.6 KB

Whoops! Forgot to put the rename in the previous patch...

New patch attached.

-mike

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Do we have any tests with migrating options fields with options values with a . in?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@ultimike if you set up your git config to use renames = copies then that patch would be way smaller and easier to review. See https://www.drupal.org/documentation/git/configure

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Setting back to needs work for #13 since the current patch and issue title are misaligned. It would be good to prove that options with dots in can be migrating - which is what caused the original report.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2302253-16.patch10.03 KB

Addressing Alex's comments:

  1. Heh - good call on us missing the original intent of this issue. I just updated the patch to include a test for dots in select options. I also moved the forward- and backslash tests to select widgets, as originally intended.
  2. Thanks for the tip on "renames = copies" - very helpful.

Updated patch attached.

Thanks,
-mike

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

This seems to address Alex's concern.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f34368b and pushed to 8.0.x. Thanks!

Yep all my concerns addressed.

  • alexpott committed f34368b on 8.0.x 
    Issue #2302253 by ultimike | Ryan Weal: Fixed User profile "selection"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.