We currently have this CSS in the Seven style.css:

/**
 * Page layout.
 */
#page {
  background: #fff;
  color: #333;
  margin-left: 0.8125em;
  margin-right: 0.8125em;
  position: relative;
}
@media screen and (min-width:28.125em) { /* 450px */
  #page {
    margin-left: 1.25em;
    margin-right: 1.25em;
  }
}
@media screen and (min-width:45em) { /* 720px */
  #page {
    margin-left: 2.5em;
    margin-right: 2.5em;
  }
}

We don't need any of it, the margins are now being handled by the generic class .layout-container in layout.css.

background: #fff;
color: #333;

The default browser background is white, so this is not needed. The color declaration should go on the the body tag in seven.base.css.

Remaining tasks

Remove all #page CSS from Seven
Add color: #333 to the body tag in seven.base.css
Remove #page from Seven's page.html.twig file

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

Issue summary: View changes
LewisNyman’s picture

Issue tags: +dreammarkup
er.pushpinderrana’s picture

Status: Active » Needs review
FileSize
1.79 KB

Please review attached patch.

LewisNyman’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
462.52 KB
233.02 KB

Great! :) Everything looks the same as before, but now with less markup and CSS.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal8-id-page-removed-2298001-3.patch, failed testing.

The last submitted patch, 3: drupal8-id-page-removed-2298001-3.patch, failed testing.

LewisNyman’s picture

er.pushpinderrana’s picture

Status: Needs work » Needs review
FileSize
1.82 KB

Here is rerolled patch.

star-szr’s picture

Title: Remove #page » Remove #page CSS from Seven
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

The only difference between #9 and #3 is fixing the conflict, so back to RTBC. I verified that with the patch applied there are no references to #page in Seven's CSS.

Thanks @er.pushpinderrana!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Less css to maintain - nice!

Committed d29ed30 and pushed to 8.x. Thanks!

  • alexpott committed d29ed30 on 8.x
    Issue #2298001 by er.pushpinderrana | LewisNyman: Remove #page CSS from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.