We currently have this CSS in the Seven style.css:
/**
* Page layout.
*/
#page {
background: #fff;
color: #333;
margin-left: 0.8125em;
margin-right: 0.8125em;
position: relative;
}
@media screen and (min-width:28.125em) { /* 450px */
#page {
margin-left: 1.25em;
margin-right: 1.25em;
}
}
@media screen and (min-width:45em) { /* 720px */
#page {
margin-left: 2.5em;
margin-right: 2.5em;
}
}
We don't need any of it, the margins are now being handled by the generic class .layout-container
in layout.css.
background: #fff;
color: #333;
The default browser background is white, so this is not needed. The color declaration should go on the the body tag in seven.base.css.
Remaining tasks
Remove all #page CSS from Seven
Add color: #333 to the body tag in seven.base.css
Remove #page from Seven's page.html.twig file
Comment | File | Size | Author |
---|---|---|---|
#9 | drupal8-id-page-removed-2298001-9.patch | 1.82 KB | er.pushpinderrana |
#4 | Screenshot 2014-07-05 10.57.45.jpg | 233.02 KB | LewisNyman |
#4 | Screenshot 2014-07-05 10.57.15.jpg | 462.52 KB | LewisNyman |
Comments
Comment #1
LewisNymanComment #2
LewisNymanComment #3
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedPlease review attached patch.
Comment #4
LewisNymanGreat! :) Everything looks the same as before, but now with less markup and CSS.
Comment #8
LewisNymanNeeds reroll after #662940: "Lucida Sans Unicode" may match ugly "Lucida Bright" instead of "Lucida Sans"
Comment #9
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedHere is rerolled patch.
Comment #10
star-szrThe only difference between #9 and #3 is fixing the conflict, so back to RTBC. I verified that with the patch applied there are no references to #page in Seven's CSS.
Thanks @er.pushpinderrana!
Comment #11
alexpottLess css to maintain - nice!
Committed d29ed30 and pushed to 8.x. Thanks!