Problem/Motivation

Follow-up to #1111224: Introduce .gitattributes to end the CRLF/LF and binary diff horror, and detect/auto-fix whitespace errors

The .gitattribues files specifies the file type for certain extensions (like *.module is a PHP file) so that the hunk headers are more useful. From http://www.kernel.org/pub/software/scm/git/docs/gitattributes.html

diff

The attribute diff affects how git generates diffs for particular files. It can tell git whether to generate a textual patch for the path or to treat the path as a binary file. It can also affect what line is shown on the hunk header @@ -k,l +n,m @@ line, tell git to use an external command to generate the diff, or ask git to convert binary files to a text format before generating the diff.

However, we are missing the .theme file from this list, so we aren't getting less-awesome patches against a theme's PHP code.

Proposed resolution

1 line change to .gitattributes to add .theme.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 2297707-1-gitattributes-theme.patch1.16 KBjohnalbin

Comments

johnalbin’s picture

Assigned: johnalbin » Unassigned
Status: Active » Needs review
StatusFileSize
new1.16 KB
dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9875f43 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.