Remove the check_plain function.

Note a new occurrence has appeared this patch fixes that and kills said function

Meta Issue.
#2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

CommentFileSizeAuthor
#6 drupal8-removed-check-plain-deprecated-6.patch732 byteser.pushpinderrana
check-plain-remove.patch1.26 KBmarcingy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Needs review » Reviewed & tested by the community

Looks good.

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Reviewed & tested by the community » Needs review

Looking again, does this need a change record?

Moving back to Needs review.

marcingy’s picture

marcingy CreditAttribution: marcingy commented

Most items that do removal seem to be going in without a change record, so not sure what the rule is to be honest...

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Needs review » Needs work
Issue tags: +Needs change record

Any API that exists in Drupal 7 but not in Drupal 8, or has changed, should be covered by a change record. The core maintainers may not always spot when a change record is needed, but that doesn't mean we should be encouraging patches to be committed without appropriate change records.

We should also update any other change records that refer to check_plain.
https://www.drupal.org/list-changes/published?keywords_description=check...

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Assigned: marcingy » Unassigned

As I say most deprecated functions are not getting change records on removal, so lets get a policy in place for doing rather than randomly selecting an issue as this one has been. Unassigning and unfollowing.

er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana commented
Status: Needs work » Needs review
FileSize
drupal8-removed-check-plain-deprecated-6.patch732 bytes

As all usage of check_plain() function already removed from repository, so now we can also remove this function from bootstrap.inc file.

Please review the attached patch as above patch is unable to apply.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

grep couldnt find anything else than the function itself

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Thanks for the change record. Since this is one of the top most-used functions in D7, I expanded the title a bit to explicitly include the name of the functions there so people can find it easily.

Committed and pushed to 8.x. Thanks!

  • webchick committed 0ae0cdb on 8.x 
    Issue #2297487 by er.pushpinderrana, marcingy: Remove the check_plain...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.