Typo in "RulesPluginFeaturesIntegrationInterace", I'm pretty sure it's an Inter"f"ace :-)

Patch in 1 minute.

CommentFileSizeAuthor
#3 2297087-3.patch3.51 KBTR
#1 2297087-1.patch3 KBdonSchoe
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

donSchoe’s picture

donSchoe CreditAttribution: donSchoe commented
Status: Active » Needs review
FileSize
2297087-1.patch3 KB

This is really just a minor thing.

Pass the following option to git commit to attribute authorship to the author:
--author="donschoe <donschoe@1017700.no-reply.drupal.org>"

TR’s picture

TR CreditAttribution: TR commented
Version: 7.x-2.7 » 7.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

Any reason not to commit this? It's clearly wrong, and the issue has come up several times.

Patch still applies four years later, and tests still pass.

TR’s picture

TR CreditAttribution: TR commented
FileSize
2297087-3.patch3.51 KB

The only caveat I can think of is that contributed modules might be implementing the wrongly-spelled interface. So I've added a compatibility layer to the patch - the mis-spelled interface is still defined, but defined as a simple extension of the correctly-spelled interface. That should avoid any problems with contributed modules.

  • TR committed 77bb493 on 7.x-2.x 
    Issue #2297087 by donSchoe, TR: Typo in...
TR’s picture

TR CreditAttribution: TR commented
Status: Reviewed & tested by the community » Fixed

Committed #3.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented

This causes fatal errors when upgrading Rules module, an update function is proposed in #3334495: RulesPluginFeaturesIntegrationInterface does not exist and could not be loaded faces.inc to prevent that.