I'm getting notice:

Notice: Undefined index: attributes in theme_picture_formatter() (line 574 of /sites/all/modules/contrib/picture/picture.module).

because an image doesn't have alt/title text set.

Changing:

$item['attributes'] = $variables['attributes'];

to:

$item['attributes'] = isset($variables['attributes']) ? $variables['attributes'] : array();

in theme_picture_formatter gets rid of the notices.

I can make a patch.

CommentFileSizeAuthor
#2 picture-notice_undefined-2297039-2.patch888 byteskristen pol

Comments

attiks’s picture

attiks commented
Status: Active » Needs work

If you upload a patch, you'll get eternal credit ;-)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs work » Needs review
StatusFileSize
new picture-notice_undefined-2297039-2.patch888 bytes

Here's the patch. :)

(Updating attribution on November 23, 2015.)

attiks’s picture

attiks commented
Status: Needs review » Fixed

It didn't apply anymore ;-)

  • attiks committed 43d8d72 on 7.x-2.x authored by Kristen Pol 
    Issue #2297039 by Kristen Pol: Fixed Notice: Undefined index: attributes...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.