API page: https://api.drupal.org/api/drupal/core%21includes%21theme.inc/group/cont...

Enter a descriptive title (above) relating to Content markers, then describe the problem you have found:

This topic mentions theme_mark(). This does not exist in Drupal 8. It should instead refer to mark.html.twig.

CommentFileSizeAuthor
#6 2296775-content-markers_1.patch468 bytesgauravkhambhala
#4 2296775-content-markers.patch463 bytesgauravkhambhala

Comments

gauravkhambhala’s picture

gauravkhambhala commented
Assigned: Unassigned » gauravkhambhala
gauravkhambhala’s picture

gauravkhambhala commented

@jhodgdon Could you point out how to refer mark.html.twig in the documentation?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Yes: Just put the file name into the documentation, such as:

This something something uses the mark.html.twig file something something.

gauravkhambhala’s picture

gauravkhambhala commented
Status: Active » Needs review
StatusFileSize
new 2296775-content-markers.patch463 bytes

Thank you @jhodgdon for the tips. Added @see reference as well. Here is the patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

OK... We probably don't really need the @see lines, because both the function and the Twig file are mentioned in the previous line?

If you feel the @see lines are a good idea, there needs to be a space between the text and those @see lines.

So, either add a blank line or just take them out... your choice, either way is fine! Thanks!

gauravkhambhala’s picture

gauravkhambhala commented
Status: Needs work » Needs review
StatusFileSize
new 2296775-content-markers_1.patch468 bytes

Added line in between. Please review.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6f9cead and pushed to 8.0.x. Thanks!

  • alexpott committed 6f9cead on 8.0.x 
    Issue #2296775 by gauravkhambhala | jhodgdon: Fixed Content Markers...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.