Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June._resumable_download_download currently uses module_invoke_all to invoke all instances of hook_file_download. As documented in the comments in file_download in file.inc, module_invoke_all will use array_merge_recursive instead of array_merge, and if more than one module implements this hook, this can result in incorrect header data - for example, trying to pass an array for "content-type" instead of a single value, which happens to cause Chrome's built in PDF reader to choke (which is what caused me to discover the issue). _resumable_download_download should instead manually loop thru invoking hook_file_download for all modules that implement it and use array_merge instead of array_merge_recursive (just as file_download does).
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | chrome-pdf-reader-error.png | 6.22 KB | bohus ulrych |
| #9 | headers.png | 10.02 KB | bohus ulrych |
| #9 | headers-array.png | 39.54 KB | bohus ulrych |
| #9 | ie-console.png | 2.09 KB | bohus ulrych |
| #8 | resumable_download-do_not_use_module_invoke_all_for_hook_file_download-2295897-8.patch | 631 bytes | olarin |
Comments
Comment #1
olarin commentedPatch to do that thing I just said.
Comment #2
olarin commentedComment #3
sinasalek commentedTx Olarin, i'll test and commit your patch
Comment #4
olarin commentedThe code from core that this duplicates has been abstracted out into a helper function in the latest version of core - file_download_headers() - so we might want to change this patch to call that helper function now rather than duplicate its code.
Comment #5
ñull commentedPatch for the related issue uses this helper function as a fix.
Comment #6
sinasalek commentedThanks for clarification, will be committed alongside the related issue
Comment #7
olarin commentedThis new version of the patch should be functionally identical to the last one, but takes advantage of the file_download_headers() function that has since been added to core (which basically just encapsulates the exact code I copy-pasted from core in the first place).
Comment #8
olarin commentedArgh, I seem to have done something with the patch file in 7 that made drush make not want to apply it (some kind of whitespace issue maybe?), let's try that again.
Comment #9
bohus ulrychHi all,
thank you all for helping me to solve my issue - patch #8 works great. Without this module I was not able too seek in the video in Chrome.
Maybe it would worth to create new module version with this patch included, it took me few hours to realize that my issue is related to this topic. Title "resumable_download should mimick core file module in avoiding module_invoke_all" doesn't help too much.
In my case I hade these symptoms of the duplicated headers - see more on screenshots:
1 - video file was not played in Internet explorer (IE11) because of "MEDIA12899: AUDIO/VIDEO: Unknown MIME type"
2 - PDF was not rendered in the Chrome's PDF reader "Failed to load PDF document"
(both private files, after applying patch works like charm)
Hopefully these keywords can save time to someone.
Comment #10
sinasalek commentedNOTICE: I only applied the patches, i have not been able to test it, if someone confirm that everything works properly i can create a new release
https://www.drupal.org/project/resumable_download/releases/7.x-1.x-dev