Remove arg()

Nice.

Truly the end of an era. arg() was added in the first days of 2003, debuted in Drupal 4.1.0. Few things as ancient as those. Only getting rid of node_invoke (from 2001) last summer compares.

Committed 0a54fea and pushed to 8.x. Thanks!

This killed by code. Can you share an example for the upgrade, please? This is inside hook_page_alter():

    if (\Drupal::moduleHandler()->moduleExists('search') && $config->get('track.site_search') && arg(0) == 'search' && $keys = google_analytics_search_get_keys()) {
      // hook_preprocess_search_results() is not executed if search result is
      // empty. Make sure the counter is set to 0 if there are no results.
      $url_custom = '(window.google_analytics_search_results) ? ' . Json::encode(url('search/' . arg(1), array('query' => array('search' => $keys)))) . ' : ' . Json::encode(url('search/' . arg(1), array('query' => array('search' => 'no-results:' . $keys, 'cat' => 'no-results'))));
    }

This looks like serving a specific need.

Please note that:

• arg(0) == 'search' matches all paths/routes starting with search. e.g. search/node or search/foo or search/bar
• arg(1) gave me node or any other keyword depending on the path search/node or search/foo or search/bar

I cannot see how I can implement this with RouteMatch.

@hass
Please have a look at https://www.drupal.org/node/2274705 and have a look at available routes defined by the search module:
search.view, search.view_$entity_id. This should be enough for you to solve the question for yourself. Please fix the duplicated support question.

I have read https://www.drupal.org/node/2274705, but i do not understand how this could help. This change notice does not help me solving the migration. I have no fixed route. This is all dynamic. It's also not possible to grab the path elements. There is no duplicate support question open.

If not possible we may need to rollback the patch here.

And what about arg(1) value? This is all missing in the changelog message and needs documentation.

We need to update change records... eg. https://www.drupal.org/node/2088511

Why are you not documenting how it could be upgrade from arg? For me this is not really easy to guess.

@ParisLiakos: \Drupal::routeMatch()->getParameter('entity')->getPath(); does not return anything.