Hello,
I just realized that commons_media is using commons_groups_get_group_content_entity_types(), but it hasn't got commons_groups as dependencie.
This could lead to a Fatal error: Call to undefined function commons_groups_get_group_content_entity_types() when disabling some modules/features.
My use case, could be tricky because of my config, but these where the steps:
- drush dis title -y
- The following extensions will be disabled: title, commons_bw, commons_pages, commons_posts
- drush cc all
- Fatal error: Call to undefined function commons_groups_get_group_content_entity_types()
@devincarlson talked to me in IRC (thanks!) and told me that could be better to use commons_entity_integration_info() instead.
I've attached an aproaching patch (3.14 version, maybe not very well indented and maybe the path to the root folder of the module is not good), if you guys think that this is the way to do it, I will reroll it in dev version.
Comments
Comment #1
tuwebo commentedBetter to check for isset, sorry about that.
Comment #2
tuwebo commentedMaking the patch relative to commons_media
Comment #3
tuwebo commentedChanging issue title and patch reroll to the 7.x-3.x version
Comment #4
japerryFixed! Indeed commons_entity_integration_info() is the way to go. I did some minor cleanup of the patch and tested, and it looks good with features showing default still.