I commented about this in https://drupal.org/node/2208299, but it really is a separate issue. I've noticed you have several issues related to different field types not being supported. But you could support all field types (although I realize the Link field is an exception) with the following patch. Otherwise, this is a great module.

CommentFileSizeAuthor
#8 referring.png2.49 KBpaulwdru
#8 notice multiple.png5.89 KBpaulwdru
#4 multiple_fields_remove_button-support-all-multiple-field-types-2287803-3-D7.patch2.47 KBlikewhoa
#3 multiple_fields_remove_button-support-all-multiple-field-types-2287803-2-D7.patch1.19 KBlikewhoa
#1 multiple_fields_remove_button.better_field_support.2287803.patch1.18 KBsprocketman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sprocketman’s picture

sprocketman CreditAttribution: sprocketman commented
FileSize
multiple_fields_remove_button.better_field_support.2287803.patch1.18 KB
BarisW’s picture

BarisW CreditAttribution: BarisW commented

Patch works, although it need a re-roll. ++

likewhoa’s picture

likewhoa CreditAttribution: likewhoa commented
Status: Active » Needs review
FileSize
multiple_fields_remove_button-support-all-multiple-field-types-2287803-2-D7.patch1.19 KB

re-rollin

likewhoa’s picture

likewhoa CreditAttribution: likewhoa commented
FileSize
multiple_fields_remove_button-support-all-multiple-field-types-2287803-3-D7.patch2.47 KB

re-rollin this patch to have fix from #2191731: Doesn't work on entity reference fields because my entityreference fields with multiple values stopped working. This patch ports that fix into this, so we might want to see which issue to keep using.

asghar’s picture

asghar CreditAttribution: asghar commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

paulwdru’s picture

paulwdru CreditAttribution: paulwdru commented
Version: 7.x-1.x-dev » 7.x-1.5
Priority: Normal » Major
Status: Closed (fixed) » Active

Hi,

I applied patch #4 on multiple_fields_remove_button-7.x-1.4.zip and it worked for many contrib modules, namely email field, advanced link, phone number and etc.

But multiple_fields_remove_button-7.x-1.5.zip does NOT have patch #4 committed, how come maintainer said that it was fixed in #5 ? Patch #4 also failed to apply on multiple_fields_remove_button-7.x-1.5.zip.

Now I change to use multiple_fields_remove_button-7.x-1.4.zip with patch #4.

I reopen this issue and hopefully #4 to be committed in the new release so as to support all modules/widgets.

Thanks

paulwdru’s picture

paulwdru CreditAttribution: paulwdru commented
FileSize
notice multiple.png5.89 KB
referring.png2.49 KB

Hi,

I just noticed that there's an error notice with multivalue Entity Reference module
notice error

Also, there should NOT be a REMOVE button for checkboxes widgets, not logic
referring

Any ideas ? Thanks

Gomez_in_the_South’s picture

Gomez_in_the_South CreditAttribution: Gomez_in_the_South commented

Just wanted to echo what paulwdru wrote in #7.
7.x-1.5 doesn't include the patch from #4 as is suggested when this issue was marked as Fixed.

semjuel’s picture

semjuel CreditAttribution: semjuel commented
Status: Active » Closed (outdated)

The Drupal 7 module version is not supported. I am closing this issue.