Whilst working on an issue I notice SchemaCheckTrait::checkConfigSchema() can fail to report errors.

Files: 
CommentFileSizeAuthor
#7 2287193.7.patch3.5 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,493 pass(es). View
#7 2287193-test-only.7.patch3.02 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,517 pass(es), 1 fail(s), and 0 exception(s). View
#1 2287193.1.patch769 bytesalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,510 pass(es). View

Comments

alexpott’s picture

FileSize
769 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,510 pass(es). View

Let's see what fails.

tim.plunkett’s picture

Priority: Normal » Major

Oh my.
Do we have tests for this?
This one is no longer just a test helper, since it was moved out...

tim.plunkett’s picture

Status: Active » Needs review

Guessing this will pass. I really hope so.

xjm’s picture

Issue tags: +Needs tests

That's pretty classic. Test coverage possible?

xjm’s picture

Title: checkConfigSchema can fail to report errors » checkConfigSchema() can fail to report errors
Gábor Hojtsy’s picture

Status: Needs review » Needs work

Looks good :) We could theoretically add a config file with some invalid schema in elements other than the first and see how that acts before/after patch.

alexpott’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
3.02 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,517 pass(es), 1 fail(s), and 0 exception(s). View
3.5 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,493 pass(es). View

With a test. The test only patch is also the interdiff :)

The last submitted patch, 7: 2287193-test-only.7.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Yay, looks good, thanks!

  • Commit 7872b9a on 8.x by catch:
    Issue #2287193 by alexpott: Fixed checkConfigSchema() can fail to report...
catch’s picture

Status: Reviewed & tested by the community » Fixed

This looks fine and is blocking another critical issue.

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.