I would like to propose the following additions to clarify the upgrade.txt file for version 5 and possible version 6 as well.

The first clarified that the "Drupal Core - Requirements" and "Core - Options" modules should not be disabled. this was based on a response at http://drupal.org/node/228509

The second is to add a note to "disable clearn urls." I have seen this issue come up on the forums so I suppose that it should be in the upgrade instructions too.

If this is not the right place for this material let me know.

CommentFileSizeAuthor
#9 228598.patch788 bytesnvahalik
#8 228598.patch789 bytesnvahalik
#7 228598.patch791 bytesnvahalik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keith.smith’s picture

Title: Suggested revisions to Upgrade.txt for version 5 and 6 » Suggested revisions to Upgrade.txt
Project: Documentation » Drupal core
Version: » 7.x-dev
Component: Installation » documentation

Moving to Drupal core (documentation) as this contemplates a change to UPGRADE.txt. And, resetting the version to 7 -- patches are first worked out in the current HEAD version and then backported as necessary.

keith.smith’s picture

On the need for the change itself, does the confusion in the first case arise from not knowing what is or is not a "contributed module"? UPGRADE.txt says that all contributed modules should be disabled; by definition, no core modules (either required or optional) are contributed modules. But, I can see this possibly be confusing to someone -- as the issue you referenced indicates -- that is not familiar with the Drupal usage of "core" and "contributed".

On the Clean URLs issue, I'm not aware of an issue here with upgrading (but there may well be one). If there is a concrete issue that you can point to, then we should possibly handle it in a separate issue (and keep this one specific to your first item).

Thomasr976’s picture

Keith,

Thanks for the prompt response.

I think that anyone who is relatively new may not fully appreciate the distinctions between Core and Contributed modules. I guess what confused me was the idea of Core - Basic and Core - Options. I was having problems with my upgrade. As you know, when that happens, one slows down and scrutinizes everything. The upgrade.txt is the bible for me and should have the necessary specificity for several audiences including newbies.

I still consider myself a newbie even though I have been learning Drupal for a couple of months. So anything that is very specific is helpful and will be beneficial. Some will have very little experience and want to upgrade to a different version just to see how easy it is.

Whatever you think is appropriate with the second issue is fine.

On the issue of Clean URLs, that seems to be relevant only when one is upgrading and moving site to another location. See http://drupal.org/node/220600#comment-726297. As I have not done this yet but will soon, I thought it might be a relevant.

thanks

jhodgdon’s picture

Clean URLs and moving to a different site -- that is not relevant to upgrade.txt, which is discussing how to upgrade to a new version of Drupal on the same site.

Regarding disabling modules... The Drupal 7 version of UPGRADE.txt says:
5. Disable all custom and contributed modules.

It sounds like there could be confusion because people don't know what "custom and contributed" means. I think this is valid, since the Modules pages talks about "Core - required" and "Core - optional" but doesn't say "contributed" on other modules. So we could change that to

Disable all custom and contributed (non-Core) modules.

Or just

Disable all non-core modules.

Thoughts?

jhodgdon’s picture

Title: Suggested revisions to Upgrade.txt » upgrade.txt should explain what contrib/custom modules means
Category: task » bug
jhodgdon’s picture

Issue tags: +Novice

Looks like a good project for a novice Drupal conributor

nvahalik’s picture

Status: Active » Needs review
FileSize
791 bytes

I'm your Novice!

nvahalik’s picture

FileSize
789 bytes

Patch rerolled without EOL spaces.

nvahalik’s picture

FileSize
788 bytes

Per cwgordon7's request. Double-checked the 80 char wrap and used only a space after periods.

cwgordon7’s picture

Status: Needs review » Reviewed & tested by the community

Nice! This is rtbc. :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

This is a nice clarification! Committed to HEAD. :)

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.