Follow-up to #2282161: Split off link/url generation trait

Problem/Motivation

Drupal\Core\Breadcrumb\BreadcrumbBuilderBase class has just two traits use once #2282161: Split off link/url generation trait is in.

Proposed resolution

Remove this class and use traits on all classes extending this base.

Remaining tasks

Issue patch
test

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#2 bye-bye-BreadcrumbBuilderBase.patch6.21 KBjibran

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Postponed » Active

#2282161: Split off link/url generation trait is in.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new bye-bye-BreadcrumbBuilderBase.patch6.21 KB
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

nice, looks good to me.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

We may need to update https://www.drupal.org/node/2106757 and https://www.drupal.org/node/2026025 once this patch is in.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1594e52 and pushed to 8.x. Thanks!

  • alexpott committed 1594e52 on 8.x 
    Issue #2283385 by jibran | vijaycs85: Remove BreadcrumbBuilderBase.
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue tags: +Needs change record updates

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Closed (fixed) » Needs work

Needs change record updates

Crell’s picture

Crell commented
Status: Needs work » Fixed
Issue tags: -Needs change record updates

I unpublished https://www.drupal.org/node/2106757 as it is no longer relevant and updated https://www.drupal.org/node/2026025 accordingly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.