Problem/Motivation

@see user_cancel_confirm_form() should be removed from comments for hook_user_cancel_methods_alter() in /core/modules/user/user.api.php and for user_cancel_confirm() in /core/modules/user/user.pages.inc. This function no longer exists. The user cancel form can be found in /core/modules/src/Form/UserCancelForm.php.

Proposed resolution

Remove the @see comments.

Remaining tasks

  1. Remove the @see comment in hook_user_cancel_methods_alter() in /core/modules/user/user.api.php
  2. Remove the @see comments in user_cancel_confirm() in /core/modules/user/user.pages.inc.
CommentFileSizeAuthor
#14 core-modify-two-docblocks-2281699-14.patch1.04 KBpushpinderchauhan
#14 interdiff-2281699-6-14.txt990 bytespushpinderchauhan
#6 core-modify-two-docblocks-2281699-6.patch978 bytesjoshi.rohit100
#1 core-modify-two-docblocks-2281699-2.patch979 bytesesod

Comments

esod’s picture

esod commented
Status: Active » Needs review
StatusFileSize
new core-modify-two-docblocks-2281699-2.patch979 bytes

patch attached.

darol100’s picture

darol100 commented

@esod,

I test your patch out on simplytest.me and seem to be working fine.

darol100’s picture

darol100 commented

@esod,

I test your patch out on simplytest.me and seem to be working fine.

darol100’s picture

darol100 commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: core-modify-two-docblocks-2281699-2.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new core-modify-two-docblocks-2281699-6.patch978 bytes

Please review updated patch as last patch failed.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

#6 is RTBC. I can only find the two references to user_cancel_confirm_form() that are mentioned in the issue summary. #6 removes them both.

giammi’s picture

giammi commented

Did a search in /core/modules/user/user.api.php and /core/modules/user/user.pages.inc. for @see user_cancel_confirm_form() in the functions mentioned in the summary. Can confirm that #6 removed @see user_cancel_confirm_form() from the comments

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: core-modify-two-docblocks-2281699-6.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review

Don't know why test failed as it was cleared by bot early.

linl’s picture

linl commented

6: core-modify-two-docblocks-2281699-6.patch queued for re-testing.

linl’s picture

linl commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC. Looks like it was a testbot glitch before.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

How about replacing them with @see \Drupal\user\Form\UserCancelForm

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2281699-6-14.txt990 bytes
new core-modify-two-docblocks-2281699-14.patch1.04 KB

Incorporated #13 point as suggested by @alexpott, please review attached patch.

linl’s picture

linl commented
Status: Needs review » Reviewed & tested by the community

Thanks, er.pushpinderrana. Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Remove @see user_cancel_form() comments » Update @see user_cancel_form() comments
Status: Reviewed & tested by the community » Fixed

Committed 69c6463 and pushed to 8.x. Thanks!

  • alexpott committed 69c6463 on 8.x 
    Issue #2281699 by er.pushpinderrana, joshi.rohit100, esod | mirie: Fixed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.