There are a few issues with missing translations:
1. commons_bw.module:
Please replace strtolower() with t(). strtolower may work for English, but is awfull in other languages. (This is a fix 2 with 1)
2. commons_groups.module
Node type is not translated
3. commons_origins/template.php
Node type is not translated
Please find my suggested patches for all issues attached.
cheers,
solwflyer
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | commons_events_module_2.patch | 1023 bytes | slowflyer |
| template_php.patch | 687 bytes | slowflyer | |
| commons_origins_template_php.gif | 6.77 KB | slowflyer | |
| commons_groups_module.patch | 779 bytes | slowflyer | |
| commons_groups.gif | 5 KB | slowflyer |
Comments
Comment #1
guruslot commentedThanks slowflyer!
This is what I expected so long. I will report in case of some problems.
But I'd like also report on the other related issue:
When user liked a node, the bundle name is not translated within the message - [message:field-target-nodes:0:type] still English.
Comment #2
slowflyer commented@guruslot I did not find a solution for the issue with the message when a user liked some content.
I removed the content type from the message. I think it is not the most important piece of information. I can live without it.
Comment #3
devin carlson commented#1 + #2 should now be fixed with https://drupal.org/commitlog/commit/14828/2d4f7050780bad18607c0a7e452498... and the associated page titles should be fixed with https://drupal.org/commitlog/commit/14828/d68e15565c5451bdaac8419c310c2d....
#3 works as designed;
node_type_get_type()returns the translated content type name and I'm able to use the translation interface to add translations for Post, Polls, Questions, etc.Comment #4
guruslot commentedHi David.
The problem is that despite of you are able to add a translations for bundle type, the translation you've done not used.
Comment #6
slowflyer commentedFor the events the translation of the title is still not correct.
Comment #7
lsolesen commented@slowflyer Can you point us to the module files where this is a problem?
Comment #8
slowflyer commented@Isolesen: That has been my problem, I did'nt get the file, after changes in 7.3.15.
I compared the commons posts with commons events and found some new lines of code for the posts missing for events.
Just added them to commons_events.module and everything is fine now.
See attached patch.
Cheers,
slowflyer
Comment #9
devin carlson commented@slowflyer Thanks for the patch!
I've committed it to Commons 7.x-3.x but left out the attendee access changes as they will be addressed in a separate issue.