Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up to #2016629: Refactor bootstrap to better utilize the kernel
$conf_path
is not found in settings.php
Comment | File | Size | Author |
---|---|---|---|
#1 | 2280383-1.patch | 549 bytes | andypost |
Comments
Comment #1
andypostComment #2
sunWhy is
$conf_path
no longer defined when settings.php is read-in?That sounds like a major bug.
Nevertheless, changing this to use __DIR__ would be fine either way.
Comment #3
donquixote CreditAttribution: donquixote commentedI like this, __DIR__ is always preferable if we know that it has to be in the same directory.
Even if the
$conf_path
variable DID exist, I would still prefer __DIR__.rtbc from me.
Unless you want more feedback from others?
Comment #4
sunWe definitely need to figure out what happened to the
$conf_path
variable. It should be set in the local scope and be available whensettings.php
is loaded.Comment #5
donquixote CreditAttribution: donquixote commentedIt was renamed to $site_path.
Old code in drupal_settings_initialize(), removed in #2016629:
New code in DrupalKernel::initialize(), added in #2016629:
Comment #6
donquixote CreditAttribution: donquixote commentedDo we need it there? What would be a use case?
And would it be ok if people have to type $site_path instead? Imo, $site_path is even more logical..
Comment #7
neclimdulMy bad, but that's definitely better any ways. Leaking the implementation of the method into the include makes re-factoring like this harder.
Comment #8
alexpottCommitted eb3e786 and pushed to 8.x. Thanks!