alexpott asked me to look at how bad it'll be if I revert StorableConfigBase and perhaps fix it in the callers. Let's see. This is not part of the official series.
Spent most of the day on that issue, narrowed it down a bit and worked with @markcarver who wrote trans block. We'll try again a bit tomorrow and Saturday to figure out what is messing up with the node tree.
It's currently double escaping inside the trans block for non filtered vars. twig is passing the escaped string to translate and escaping again.
Nice work all for getting it down to one fail! Especially @chx++
FYI I left my cord at the con and out of juice, need to find, but or borrow one in the morn before sprint.
Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.
Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.
Comments
Comment #1
chx commentedComment #3
chx commentedComment #4
chx commentedComment #5
chx commentedComment #12
chx commentedComment #13
chx commentedComment #16
chx commentedComment #17
heddnComment #19
chx commentedComment #20
chx commentedComment #21
heddnComment #24
heddnComment #26
chx commentedheddn, DO NOT MERGE HEAD YOU BROKE THE TREE!
Comment #27
chx commentedComment #28
chx commentedComment #30
chx commentedalexpott asked me to look at how bad it'll be if I revert StorableConfigBase and perhaps fix it in the callers. Let's see. This is not part of the official series.
Comment #31
bdragon commentedtestbot, I summon thee.
Comment #33
chx commentedComment #35
joelpittetSpent most of the day on that issue, narrowed it down a bit and worked with @markcarver who wrote trans block. We'll try again a bit tomorrow and Saturday to figure out what is messing up with the node tree.
It's currently double escaping inside the trans block for non filtered vars. twig is passing the escaped string to translate and escaping again.
Nice work all for getting it down to one fail! Especially @chx++
FYI I left my cord at the con and out of juice, need to find, but or borrow one in the morn before sprint.
Comment #36
chx commentedI removed the session hack.
Comment #38
chx commentedComment #39
chx commentedComment #41
chx commentedComment #43
joelpittetComment #46
joelpittetComment #47
chx commentedReverting the AjaxResponseRender tentatively.
Comment #48
joelpittetmerged in 8.x with filters.
Comment #49
chx commentedComment #51
chx commentedComment #52
chx commentedComment #53
chx commentedComment #56
chx commentedComment #58
chx commentedComment #60
chx commentedComment #61
chx commentedComment #63
chx commentedComment #64
chx commentedComment #66
chx commentedComment #68
chx commentedComment #70
chx commentedComment #71
chx commentedComment #74
chx commentedComment #76
chx commentedComment #78
chx commentedComment #79
chx commentedComment #81
fabianx commentedComment #83
fabianx commentedComment #84
fabianx commentedComment #86
fabianx commentedComment #87
fabianx commentedComment #88
fabianx commentedComment #89
pwolanin commentedbriefly borrowing this issue for a test run :)
Comment #91
chx commentedI reverted 359cf8dc8f3475dd77c7012a409f9697eaf16f74
Comment #92
fabianx commentedComment #93
fabianx commentedComment #95
fabianx commentedComment #96
pwolanin commentedjust borrowing the bot...
Comment #97
fabianx commentedComment #99
fabianx commentedComment #100
fabianx commentedComment #103
fabianx commentedComment #104
fabianx commentedComment #105
fabianx commentedComment #107
fabianx commentedComment #108
fabianx commented.
Comment #109
fabianx commented.
Comment #110
fabianx commentedComment #111
fabianx commentedComment #112
fabianx commentedComment #115
tstoecklerComment #116
tstoecklerComment #117
tstoecklerComment #118
fabianx commented@tstoeckler: If a file is hidden during upload it won't be found by testbot ...
Comment #119
tstoeckler@FabianX: Yeah, I just realized that. That's super weird, but whatever... Thanks, though! :-)
Comment #121
tstoecklerComment #123
tstoecklerComment #125
tstoecklerComment #127
tstoecklerComment #129
tstoecklerComment #131
pwolanin commentedborrowing the bot
Comment #133
pwolanin commented131: 2256521-next.patch queued for re-testing.
Comment #135
pwolanin commentedand again...
Comment #136
tstoecklerComment #137
wim leersComment #138
wim leersComment #140
pwolanin commentedComment #141
chx commentedComment #143
chx commentedComment #145
joelpittetComment #146
joelpittetWonder if it will ignore this patch...
Comment #147
pwolanin commentedborrowing the bot
Comment #148
pwolanin commentedoops, wrong patch
Comment #151
pwolanin commentedagain
Comment #152
pwolanin commentedComment #153
pwolanin commentedhi bot
Comment #154
pwolanin commentedparts 2-5
Comment #156
pwolanin commentedlonely much, bot?
Comment #157
wim leersComment #159
wim leersOne missing semi-colon. Sigh.
Comment #161
wim leersComment #163
wim leersComment #165
tstoecklerComment #166
tstoecklerComment #170
tstoecklerdoobie-doobie
Comment #172
pwolanin commentedComment #173
MattA commentedComment #174
pwolanin commentedComment #177
tstoecklerComment #183
dpi