Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After fixing Ajax issues mentioned here https://drupal.org/node/2245331 this is an error I am getting on IE8:
Before that JavaScript parser didn't even go to this one.
This happens when ajax_el is having bind value.
A quick path goes below.
Comment | File | Size | Author |
---|---|---|---|
#8 | clientside_validations-ie8-hasOwnProperty-2279537.patch | 644 bytes | alex-mo |
#7 | clientside_validation-ie8-fix-2279537-7.patch | 879 bytes | Turek |
#4 | clientside_validation-ie8-fix-2279537-4.patch | 1.96 KB | Turek |
#1 | clientside_validation-ie8-fix-2279537-1.patch | 877 bytes | Turek |
clientside_validation-error.png | 15.54 KB | Turek |
Comments
Comment #1
Turek CreditAttribution: Turek commentedPath that worked for me - for 7.x-dev version.
Comment #2
Turek CreditAttribution: Turek commentedComment #3
attiks CreditAttribution: attiks commentedDon't you mean !=
Comment #4
Turek CreditAttribution: Turek commentedYes, you are right, and quotes around undefined :)
Thanks for a quick response.
Comment #5
attiks CreditAttribution: attiks commenteddid you add this block by accident, this was removed because it was causing problems
Comment #6
Turek CreditAttribution: Turek commentedActually this was added by git diff. I've seen it in some patches already, and thought it would be ok.
That top part is obviously not needed.
Comment #7
Turek CreditAttribution: Turek commentedThis is a correct one.
Comment #8
alex-mo CreditAttribution: alex-mo commentedI think the problem lies within call of function
changeAjax()
, not in the function itself (of course: you can always add someif
s :), but this would be working around the problem, I guess).changeAjax
gets called on line 1385 withajax_el
being 'bind' and this no identifier in the DOM (as it should), but a property name coming from the prototype ofDrupal.ajax
. IE 8 seems to be more picky when it comes to iterating over or when evaluating these (other browsers don't seem to be startled by this...) . Catching this withhasOwnProperty()
does the trick for us.Patch attach.
Comment #9
Jelle_SFixed in the latest dev version. Thanks for the patch!