Fragile form_id generation for bundlable entity forms

Seems we have no tests at all

I think no reason in tests

Test should make sure the proper name for for form when bundle name is the same as entity type name

Should be possible to use the entity_test form for that, the default bundle there is entity_test and it has a bundle key.

This absolutely needs tests. It should be easy enough to write a unit test for this, right?
It should cover both entity types with and without a bundle key.

The change looks fine.

Here's a unit test

Looks good to me, thanks @andypost!

+++ b/core/tests/Drupal/Tests/Core/Entity/EntityFormTest.php
@@ -0,0 +1,92 @@
+      array('article_node_form', array(
+        'bundle' => 'article',
+        'entity_type' => 'node',
+        'operation' => 'default',
+      )),
+      array('article_node_delete_form', array(
+        'bundle' => 'article',
+        'entity_type' => 'node',
+        'operation' => 'delete',
+      )),
+      array('user_form', array(
+        'bundle' => '',
+        'entity_type' => 'user',
+        'operation' => 'default',
+      )),
+      array('user_delete_form', array(
+        'bundle' => '',
+        'entity_type' => 'user',
+        'operation' => 'delete',
+      )),

There is no test where the entity and bundle have the same name?

The failed test shows the case:

+++ b/core/tests/Drupal/Tests/Core/Entity/EntityFormTest.php
@@ -0,0 +1,92 @@
+        'bundle' => '',
+        'entity_type' => 'user',
...
+        'bundle' => '',
+        'entity_type' => 'user',

this is the case, because the test uses Entity and it's method bundle() returns entity name

\Drupal\Core\Entity\Entity::bundle() {
return $this->entityTypeId;
}

Added case for user with bundle user.
Now fail test shows 3 failures (1 user bundle and 2 for empty bundle)

Committed and pushed to 8.x. Thanks!