ConfigManager uses $this->stringTranslation->translate('File removed') to translate strings but localise.drupal.org won't pick this up.

CommentFileSizeAuthor
#3 2276571.3.patch1.75 KBalexpott
#3 1-3-interdiff.txt2.28 KBalexpott
#1 2276571.1.patch3.67 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2276571.1.patch3.67 KB

Patch to do what the issue summary says.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Needs work

Thanks
Using the trait though doesnt mean we can stop injecting stuff, especially for core services. Lets keep this

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 1-3-interdiff.txt2.28 KB
new 2276571.3.patch1.75 KB

Okey-dokey.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 7424e46 on 8.x by catch: 
    Issue #2276571 by alexpott: Fixed Use StringTranslationTrait in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.