Currently, the Spotlight widget will turn the "Title" into a link if a value is provided. Several users have requested that the image itself should also link to the given URL. I think this probably makes sense!

CommentFileSizeAuthor
#8 spotlight_image_should-2274877-8.patch936 bytesmglaman
#4 spotlight_image_should-2274877-4.patch939 bytesmglaman
#2 spotlight_image_should-2274877-2.patch940 bytesmglaman

Comments

miromarchi’s picture

miromarchi commented
Related issues: +#2013965: ability to link images placed with image widget

I add "ability to link images placed with image widget" as a related issue, since it is the same feature request but referred to image widget.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new spotlight_image_should-2274877-2.patch940 bytes

Patch to wrap image in a link, if link provided.

electroponix’s picture

electroponix commented

I tried applying this patch to the latest "stable/non dev" version and it broke the site.
Is there a patch for the most recent version?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new spotlight_image_should-2274877-4.patch939 bytes

Wow, fail on my part, sorry. There was a missing semicolon :/. Can you try this patch?

electroponix’s picture

electroponix commented

Still breaking the site. Get the white screen and have to revert it for it to work again.

electroponix’s picture

electroponix commented

I am on 7.1.11 Should I go to the dev version?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

electroponix can you check what the exact error is? Sorry I just quick-re-rolled patch for obvious error - didn't have error when first wrote patch (obviously goofed patch somehow, though.)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new spotlight_image_should-2274877-8.patch936 bytes

Fixed up. I somehow patched/used the D6 syntax for l()? It's all correct now.

electroponix’s picture

electroponix commented

Thanks! Will try again. Sorry I didn't get bak on this sooner, lots of things in the cooker.

electroponix’s picture

electroponix commented

It worked. Thanks again. My designer is a happier camper. :)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Awesome! If it worked could you mark this issue as "Reviewed & Tested by the Community"? That way maintainers know it's a good to go fix!

electroponix’s picture

electroponix commented
Status: Needs review » Reviewed & tested by the community

The last patch works. One other suggestion is a toggle button on the spotlight to turn off the text link altogether.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

One other suggestion is a toggle button on the spotlight to turn off the text link altogether.

@electroponix: That's an interesting idea, thanks!

However, rather than adding more options to Spotlight, I'd like to suggest an alternative approach: currently, we're building the HTML for Spotlight widgets entirely in code in the hook_field_formatter_view(). Let's move that to a theme function with a template, so that it'd be easy for themers to override and change how the spotlight is rendered. I've created a new issue for it: #2334041: Move rendering of Spotlight formatter into theme function

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed!

  • dsnopek committed 78188cc on 7.x-1.x 
    Issue #2274877 by mglaman | dsnopek: Added Spotlight image should link...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.