Remove \Drupal\Core\Field\PrepareCacheInterface

+++ b/core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldType/DateTimeItem.php
@@ -104,21 +104,6 @@ public function settingsForm(array $form, array &$form_state, $has_data) {
-    // later. The date will be retrieved in UTC, the local timezone adjustment
-    // must be made in real time, based on the preferences of the site and user.
-    if (!empty($data['value'])) {
-      $data['date'] = $this->date;
-    }
-    return $data;

See comment ;)

=> timezone cache tag for date fields? Not a bug introduced here but as we remove that comment, we should fix that with fairly high priority?

The patch doesn't remove the code that is actually calling the getCachedData() methods in the content entity storage.

+++ b/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php
@@ -151,15 +150,7 @@ protected function loadFieldItems(array $entities) {
               if ($items->getFieldDefinition() instanceof FieldInstanceConfigInterface && !$items->isEmpty()) {
                 foreach ($items as $delta => $item) {
-                  // If the field item needs to prepare the cache data, call the
-                  // corresponding method, otherwise use the values as cache
-                  // data.
-                  if ($item instanceof PrepareCacheInterface) {
-                    $data[$langcode][$field_name][$delta] = $item->getCacheData();
-                  }
-                  else {
-                    $data[$langcode][$field_name][$delta] = $item->getValue();
-                  }
+                  $data[$langcode][$field_name][$delta] = $item->getValue();
                 }
               }

We only need the loop for this prepare cache check, now that this is gone, we can call $items->geValue().

Still need to figure out what to do in #597236: Add entity caching to core (I will still need a method on entities, but doesn't need to be a special interface I think).

text_filter_format_disable() and text_filter_format_update() only exist to clear the entity cache if they get disabled/changed, I assume we got that covered now with cache tags and can just remove them. Otherwise FilterSecurityTest wouldn't pass :)

I checked that we have no calls to check_markup() left on the frontpage with a bunch of nodes on a render cache hit, so this should be good to go after another round of clean-up :)

@Wim : the role of this code block remains to populate the $data array.
I think @Berdir meant $data[$langcode][$field_name] = $items->getValue(); ;-)

I'm not so sure. What if you send out e.g. digest e-mails containing a lot of nodes including token replacements, then the cached processed text would be still useful? Or, when entities are rendered to a RESTful service? Then, the optimization seems to be still valuable?

Processed is (right now) not even printed in in the rest output because it's computed ;) and yes, that means you have read access to the raw value...

Processed is (right now) not even printed in in the rest output because it's computed ;) and yes, that means you have read access to the raw value...

what's really great as this was the reason to add it as property in the first place.. :D

ad #13: good point, agreed.

+++ b/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php
@@ -151,17 +150,7 @@ protected function loadFieldItems(array $entities) {
+                $data[$langcode][$field_name][$delta] = $items->getValue();

Without the $delta.

We're getting closer ;)

I think this looks good, time for @catch to have a look...

Looks good to me too, nice to see this gone.

Committed/pushed to 8.x, thanks!

Great, updated https://drupal.org/node/2064123/revisions/view/7175651/7294389 and removed references to this interface and also updated the documentation page at https://drupal.org/node/2112677.