Following #1699128: eck__entity_access() may make everything that use entity_access() bypass the permission check. which standardized on using eck__entity_menu_access() in hook_menu() implementations, here's a patch which does the same for the access check in ECK's views handlers.

CommentFileSizeAuthor
#11 entity_access-in-eck-views-handlers-eck-2270535-11.patch3.37 KBwildfeed
#11 entity_access-in-eck-views-handlers-eck-2270535-11.patch3.37 KBwildfeed
#10 entity_access-in-eck-views-handlers-eck-2270535-10.patch3.51 KBwildfeed
#5 eck-2270535-2.patch3.56 KBswirt
#1 eck-2270535-1.patch1.75 KBles lim

Comments

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new eck-2270535-1.patch1.75 KB

Patch attached.

fmizzell’s picture

fmizzell commented
Priority: Normal » Major
fmizzell’s picture

fmizzell commented

@Les Lim Shouldn't we use entity_access?

eric.napier’s picture

eric.napier commented

@fmizzell: eck__entity_menu_access() seems to be just a wrapper function for entity_access(). Is there a reason we should use that method directly instead of through this wrapper?

swirt’s picture

swirt
he/him
Primary language English
commented
StatusFileSize
new eck-2270535-2.patch3.56 KB

This patch calls entity_access directly and adds similar handling for the 'view' operation too.

Status: Needs review » Needs work

The last submitted patch, 5: eck-2270535-2.patch, failed testing.

The last submitted patch, 5: eck-2270535-2.patch, failed testing.

The last submitted patch, 5: eck-2270535-2.patch, failed testing.

The last submitted patch, 5: eck-2270535-2.patch, failed testing.

wildfeed’s picture

wildfeed commented
StatusFileSize
new entity_access-in-eck-views-handlers-eck-2270535-10.patch3.51 KB

Re-roll eck-2270535-2.patch found in comments #5 - #9 so it can be applied to version 7.x-2.0-rc9

wildfeed’s picture

wildfeed commented
StatusFileSize
new entity_access-in-eck-views-handlers-eck-2270535-11.patch3.37 KB
new entity_access-in-eck-views-handlers-eck-2270535-11.patch3.37 KB

Re-roll eck-2270535-2.patch found in comments #5 - #9 so it can be applied to version 7.x-2.0-rc9

wildfeed’s picture

wildfeed commented
Status: Needs work » Needs review

Re-roll eck-2270535-2.patch found in comments #5 - #9 so it can be applied to version 7.x-2.0-rc9

The last submitted patch, 11: entity_access-in-eck-views-handlers-eck-2270535-11.patch, failed testing. View results

The last submitted patch, 11: entity_access-in-eck-views-handlers-eck-2270535-11.patch, failed testing. View results

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Needs work
dieterholvoet’s picture

dieterholvoet commented
Status: Needs work » Closed (won't fix)

We're dropping support for Drupal 7 since it has officially reached end of life on the 5th of January 2025.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.