Clean up ConfigImporter

Looks good to me, especially the typehint/config fixes :) I can see how some of those public methods should not be exposed to the public.

d8.configimporter.patch queued for re-testing.

This had a thousands of random fails in the automated retest. Green again.

Yeah should be back to RTBC.

Please review attached patch which also fixes 'Inline control structure' issue on line #267.

>    public function hasUnprocessedConfigurationChanges() {
> -    foreach ($this->storageComparer->getAllCollectionNames() as $collection)
> -    foreach (array('delete', 'create', 'rename', 'update') as $op) {
> -      if (count($this->getUnprocessedConfiguration($op, $collection))) {
> -        return TRUE;
> +    foreach ($this->storageComparer->getAllCollectionNames() as $collection) {
> +      foreach (array('delete', 'create', 'rename', 'update') as $op) {
> +        if (count($this->getUnprocessedConfiguration($op, $collection))) {
> +          return TRUE;
> +        }

That looks like a good additional fix.

Committed/pushed to 8.x, thanks!