The ConfigImporter contains methods that are unused, unnecessary public, a few spelling mistakes and the reInjectMe class does not match the constructor.

Files: 
CommentFileSizeAuthor
#12 d8.configimporter-12.patch6.33 KBamitgoyal
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,958 pass(es). View
d8.configimporter.patch5.6 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,691 pass(es). View

Comments

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me, especially the typehint/config fixes :) I can see how some of those public methods should not be exposed to the public.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, d8.configimporter.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review

d8.configimporter.patch queued for re-testing.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

This had a thousands of random fails in the automated retest. Green again.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, d8.configimporter.patch, failed testing.

alexpott’s picture

alexpott’s picture

Status: Needs work » Needs review

d8.configimporter.patch queued for re-testing.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Yeah should be back to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, d8.configimporter.patch, failed testing.

alexpott’s picture

Status: Needs work » Reviewed & tested by the community

Diskspace issues :(

9800673 Requested by test client #1848.

alexpott’s picture

d8.configimporter.patch queued for re-testing.

amitgoyal’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
6.33 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,958 pass(es). View

Please review attached patch which also fixes 'Inline control structure' issue on line #267.

>    public function hasUnprocessedConfigurationChanges() {
> -    foreach ($this->storageComparer->getAllCollectionNames() as $collection)
> -    foreach (array('delete', 'create', 'rename', 'update') as $op) {
> -      if (count($this->getUnprocessedConfiguration($op, $collection))) {
> -        return TRUE;
> +    foreach ($this->storageComparer->getAllCollectionNames() as $collection) {
> +      foreach (array('delete', 'create', 'rename', 'update') as $op) {
> +        if (count($this->getUnprocessedConfiguration($op, $collection))) {
> +          return TRUE;
> +        }
Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

That looks like a good additional fix.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 8327533 on 8.x by catch:
    Issue #2269323 by amitgoyal, alexpott: Fixed Clean up ConfigImporter.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.