In case a supporter did already sign up and only the subscription summary is displayed, the mollom captcha is obsolete. The same is true if the registration for the event was disabled ($event->No_Registration == 'true').

CommentFileSizeAuthor
#2 salsa_event_mollom_improvements-2269083-1.patch2.79 KBs_leu

Comments

s_leu’s picture

s_leu commented
Status: Active » Needs review

Here's a first patch for it.

s_leu’s picture

s_leu commented
StatusFileSize
new salsa_event_mollom_improvements-2269083-1.patch2.79 KB

Status: Needs review » Needs work

The last submitted patch, 2: salsa_event_mollom_improvements-2269083-1.patch, failed testing.

s_leu’s picture

s_leu commented
Status: Needs work » Needs review

2: salsa_event_mollom_improvements-2269083-1.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Need to revisit this after #2459201: Introduce caching of certain salsa entities, we noticed that this causes multiple salsa queries for the same information, so we should at least add a static cache.

Not sure I get why this needs to be in our own form alter.