In the function breadcrumbs_by_path_page_build(), if the page title added to the breadcrumb trail, it is stripping dashes from the title.

CommentFileSizeAuthor
#3 content_titles_are-2266701-3.patch648 bytesredndahead
#1 breadcrumbs_by_path_patch-2266701-1.patch546 bytesgmercer

Comments

gmercer’s picture

gmercer commented
Status: Active » Needs review
StatusFileSize
new breadcrumbs_by_path_patch-2266701-1.patch546 bytes

Here is the patch for this issue.

redndahead’s picture

redndahead commented

FYI We've been using this on production with no issues since we've submitted this patch.

redndahead’s picture

redndahead commented
StatusFileSize
new content_titles_are-2266701-3.patch648 bytes

Re-roll

nitebreed’s picture

nitebreed
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Works!

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Reviewed & tested by the community » Needs work

I think that it would be better to modify what happens in the _breadcrumbs_by_path_clean_string() function rather than bypass it completely.

redndahead’s picture

redndahead commented
Status: Needs work » Reviewed & tested by the community

The clean string function is for cleaning the last path of a url into something that looks like a title. It's not really needed in this case since it's already the title.

  • opdavies committed 64543b1 on 7.x-1.x authored by gmercer 
    Issue #2266701 by redndahead, gmercer, Nitebreed: Content titles are...
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

Committed, and tagged as 7.x-1.0-alpha13.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.