Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
MigrateDrupal6Test loads all the dumps of the different Drupal6 migrations, and tests the complete migration.
We will need similar behavior for MigrateDrupal7Test, MigrateMultilingualDrupal6 et al.
Proposed resolution
Create a MigrateFullDrupalTestBase abstract class, and move the tearDown and testDrupal methods, so they can be reused.
Remaining tasks
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2264717-3.patch | 12.43 KB | penyaskito |
Comments
Comment #1
penyaskitoComment #2
chx CreditAttribution: chx commentedgreat! the reason we are not making these properties because the files might come from different directories; indeed it's expected for multilingual and d7 both.
Comment #3
penyaskitoMissed return docs as @benjy noticed on IRC.
Comment #4
webchickThis is just moving code around so no real reason not to commit it, but...
Yikes, that looks brittle. Seems like it would be very easy for us to add a new D6 migration and for it to be forgotten in this list. In a follow-up, is there any way to have it just do "Give me all migrations that start with d6_*" since that seems to be what's wanted here?
Either way, this was a "pre-existing condition" in HEAD, so..
Committed and pushed to 8.x. Thanks!
Comment #6
chx CreditAttribution: chx commentedWhile #4 seems reasonable on the surface, that's just how things are currently. please see #2 why it is not feasible.
Later, if we have the grouping we desire then we might want to revisit this.